Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve context depending picking on picking readback, not during scene build up #1895

Closed
Wumpf opened this issue Apr 18, 2023 · 1 comment
Closed
Labels
📉 performance Optimization, memory use, etc 📺 re_viewer affects re_viewer itself 🚜 refactor Change the code, not the functionality

Comments

@Wumpf
Copy link
Member

Wumpf commented Apr 18, 2023

We should always render the same picking layer out no matter what is selected at the moment, but right now we may or may not write out InstanceKey::SPLAT for instance keys depending on whether an object or an instance is selectable. This ofc means that the picking layer needs to transfer this semantic so it can be picked up again when resolving a retrieved picking layer rectangle - 0 would mean instance 0, SPLAT means all instances. Instead, we should put this logic in the code that reads the picking layer back.

This would simplify & speed up scene setup a bit. Also, as the default picking layer instance id is zero, it would be easier/more natural to setup rendering of objects without instance ids - right now they need to use the SPLAT instance constant instead.

Related to #1893

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 📉 performance Optimization, memory use, etc 🚜 refactor Change the code, not the functionality labels Apr 18, 2023
@Wumpf
Copy link
Member Author

Wumpf commented Nov 6, 2023

Fixed by

@Wumpf Wumpf closed this as completed Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📉 performance Optimization, memory use, etc 📺 re_viewer affects re_viewer itself 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

No branches or pull requests

1 participant