Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for lidar data #4409

Open
roym899 opened this issue Nov 30, 2023 · 0 comments
Open

Improve support for lidar data #4409

roym899 opened this issue Nov 30, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@roym899
Copy link
Collaborator

roym899 commented Nov 30, 2023

Is your feature request related to a problem? Please describe.
Lidar data is quite similar to back-projected depth maps, so it would be nice to support distance-based color maps that can be changed from inside the viewer.

Raw lidar data often comes in terms of angles, distances, and per-point timestamps; processed data (projected and potentially motion compensated) typically comes as 3D point clouds in the sensor frame + sensor pose. I believe the latter would be more important to support directly.

Similar ideas apply to, for example, radar data; so maybe it would make sense to name the archetype in a more general way than just LidarScan.

Things I'm unsure of

  • I suspect raw lidar data might come in lots of different formats and conventions (i.e., how to interpret the angles to retrieve the 3D point); hence, just supporting 3D points in the sensor frame might be sufficient
  • similar to most sensors, I think the sensor pose should be the closest available transform in time not the latest, but that's a separate issue Allow Transformations to be aware of a "fixed frame" #1522
  • Should the sensor pose be logged as a transform or should there be an option to log it as part of the sensor scan? Maybe best to support both for simplicity; however, in that case, it's important that both cases behave the same way.
  • It's probably worth checking a few lidars and what data they provide (I know about return number and intensity, but maybe there's more)

Describe the solution you'd like
Add a LidarScan archetype (or something more general like RangeScan maybe) that takes 3D points and supports different color maps based on the Euclidean distance to the scan origin.

Specifically for lidar, special per-point values that might be nice to support are the return number (integer) and intensity (float).

It would be nice if the color map input could be changed between distance / return number / intensity / x-value / ...

Describe alternatives you've considered
It's already possible to log lidar scans as points, but the color map has to be calculated manually and can't be changed from inside the viewer.

@roym899 roym899 added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels Nov 30, 2023
@emilk emilk removed the 👀 needs triage This issue needs to be triaged by the Rerun team label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants