Release 1.0.0 #69
Release 1.0.0 #69
Conversation
There was a problem hiding this comment.
I think we should add a changelog, since we made major changes. I can help writing that, if you like.
Otherwise it looks good to me, we already updated the version. Thank you for adding me to the authors. :)
For releases, I have usually a release guide in my repositories, since I also tend to forget the procedure. It may be a good idea to write one and add it to this PR?
|
@dsaxton If you could add me also to PyPI that would be great, thanks! |
|
For reference, here is the release guide for iminuit: https://github.com/scikit-hep/iminuit/blob/develop/doc/README.md |
|
@HDembinski Agree about the changelog (I'll add that and start working on it soon). What's your username on PyPI? I'll add you as a collaborator. Nice that we can release through GitHub, that simplifies the process a lot. |
|
Started changelog.rst with a few of the changes if you wanted to add some notes about the interface overhaul (might want to have a section that specifically calls out that these are breaking changes). |
|
Sorry, I should have said it is hdembins on PyPI. |
Should be added as maintainer now |
|
@HDembinski feel free to make / propose edits to the changelog, I'm trying to document most everything from the closed issues |
|
@HDembinski Are you good with the minor suggested edits? Would be nice to get this out if possible (I'll likely need some help with that). |
|
Yes, all good. Sorry for being not very responsive in the last weeks, work and private life are eating up my spare time currently. Please don't wait for my feedback for the release. I think it got great! |
|
@HDembinski Following the steps here https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/ and it seems we should probably have a pyproject.toml file. I think you mentioned this in a previous issue in regard to packaging "best practices"; are you familiar with how to set this up by chance? |
|
Not really, but I can research it. |
This reverts commit d2f60a5.
|
@HDembinski Uploaded to PyPI and I think we're good to go: Python 3.8.5 (default, Aug 5 2020, 03:39:04)
[Clang 10.0.0 ] :: Anaconda, Inc. on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import resample
>>> resample.__version__
'1.0.0'Also, there are a bunch of junk releases for this package still in PyPI. Would you be opposed to us simply deleting those (I was actually experimenting with it at the time)? |
|
@dsaxton Deleting (yanking) old stuff is fine with me, but most people will never notice it is there. It is up to you :) |
@HDembinski Couple edits to setup.py before releasing the new version (I can also make you co-owner on PyPI). Let me know if there are any other loose ends you can think of that need to be taken care of before releasing (it's been two years since the last time I did this and need to refresh my memory).