Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination is not working #20

Closed
jorge-vnarvaez opened this issue Jul 23, 2023 · 5 comments · Fixed by #21
Closed

Pagination is not working #20

jorge-vnarvaez opened this issue Jul 23, 2023 · 5 comments · Fixed by #21

Comments

@jorge-vnarvaez
Copy link

When i use any provider and find images with a prompt for example "Agriculture" and then go to the pagination and select page 2, 3, 4 or anything else the image scout field doesn't fetch new images.

@shealavington
Copy link
Member

Hi,

Sorry, I'll need a few more details.

Please explain what provider you're using, the search term, directus version. Perhaps even a video.

I do believe it is working, unless the network requests are failing. Are there any network errors in the network tab of the browser dev tools?

Thanks.

@jorge-vnarvaez
Copy link
Author

Hi,

Thanks for answering me.

Provider

Unsplash && Pexels

Search term

Innovation, Agriculture

** Directus version **
10.4.3, also happens in 10.4. 2

Here's the video including the network tab log.

https://youtu.be/9iWQC3b2Cp0

@shealavington
Copy link
Member

Thanks for that detail, I take it there's no console errors?

I'm currently away from my computer for a couple of weeks (responding on phone). I will take a look at the issue upon my return.

In the meantime, I'm open to any pull requests if you get the time yourself. 🙂

@jorge-vnarvaez
Copy link
Author

I'm gonna check this weekend the code, I don't promise anything but I'll try to see what is the problem.

@shealavington
Copy link
Member

Hiya @jorge-vnarvaez. 👋

I apologise for taking so long. I have a fix for this released as Version 3.1.1. I appreciate you taking the time to raise this and additionally, any time you may have even spent debugging yourself.

You had unfortunately raised the issue just as I was starting some back-to-back travelling and as such, for the first time in a long time I had disconnected myself from doing any coding or working. Followed by getting back into my daily job this week.

Please do give the plugin another go with the latest version and let me know how it goes.

Thanks! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants