Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No gitignore file for projectet generated by this CLI #15

Closed
Lantianyou opened this issue Mar 7, 2023 · 1 comment · Fixed by #17
Closed

No gitignore file for projectet generated by this CLI #15

Lantianyou opened this issue Mar 7, 2023 · 1 comment · Fixed by #17

Comments

@Lantianyou
Copy link

Lantianyou commented Mar 7, 2023 •
edited
Loading

This is quite problematic, which might cause someone to accidentally include node_modules into git repo.
image
@Lantianyou Lantianyou changed the title No gitignore file for projectet generated by this CLI, which might include node_modules in git repo No gitignore file for projectet generated by this CLI Mar 7, 2023
@Lantianyou
Copy link
Author

Furthemore, it would be best if the @vitejs/plugin-react is replaced with @vitejs/plugin-react-swc, which is the recommended react plugin by vite.

@aaronz0 aaronz0 mentioned this issue Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Able to generate .gitignore
1 participant
@Lantianyou