New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading to @rescript/react is incompatible with most of my app’s dependencies based on reason/react #6
Comments
Hm, I think this is the moment where third party packages need to create a new npm package that does align with the new rescript & rescript-react ecosystem. Not only because it's not possible to drive two different packages with the same exposed toplevel module names, but also because the package names like bs-xyz, and the module source code are inconsistent with ReScript's recommendations. As a quick workaround, I'd copy the bs-reach / re-formality libraries into your app code and remove the dependency. bs-reach hasn't gotten any updates for quite some time, so I'd actually argue that you should copy it anyways, since you get more control over the code when you find interface mismatches. I can't find any details about ˋrescript-reasonˋ... was this a typo? |
@ryyppy it was a typo! I meant Since re-formality depend on ppx, is it straightforward to just copy the code? I've never built a ppx |
Migrated my projects:
|
@vasco3 huh that's weird... just checking re-formality, it doesn't look like it has a dependency to So as long as the library + ppx don't use any of the old \cc @alexfedoseev just to verify what reason-react apis are being used, because I can't find any hints in the source code so far |
@ryyppy Current published package contains 2 versions of the lib:
PPX version uses:
Non-PPX version uses:
Package has only one dependency and it's not |
@ryyppy on re-formality maybe it's the references to ReactEvent? |
@vasco3 @ryyppy I found a culprit: https://github.com/MinimaHQ/re-formality/blob/master/lib/bsconfig.json#L5 The package doesn't have |
Updated:
|
After more than one and a half years, all projects that are still active will already have updated the dependency to If there is still anything missing, please open an issue on that project's issue tracker. |
Some scripts that I use in my app are breaking. For example:
is there a way to fix this other than waiting for the third-party libs to catch up?
example of error
example 2
example 3
The text was updated successfully, but these errors were encountered: