Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace #1

Open
cknitt opened this issue Sep 20, 2019 · 2 comments
Open

Namespace #1

cknitt opened this issue Sep 20, 2019 · 2 comments

Comments

@cknitt
Copy link
Member

cknitt commented Sep 20, 2019

Wouldn't it be better to set the namespace in bsconfig.json instead of prefixing the file names?

(The web view component itself would then be available as ReactNativeWebView.WebView.)

@sgny
Copy link
Collaborator

sgny commented Sep 21, 2019

I wasn't too happy about the naming, but that has been what we have settled on.

Now that we have been moving bindings to their own repos, I've been thinking of moving the old WebView bindings to their own repo, so that we can remove them from the RN bindings without issue and yet allow people to remain on older versions of RN.

With such a move, I would prefer that the components be named WebView instead (and likewise for NetInfo, Slider etc).

@ryyppy
Copy link

ryyppy commented May 15, 2021

Kinda related: Due to a quite extensive upgrade from BS v7 + reason-react-native 0.61 and reason-react, I had to vendor most of the dependent reason-react-native libraries to even be able to upgrade properly.

Turned out, the ReactNativeWebview module is a 400 lines module, which could easily distributed as a single file.

Wouldn't this be a better option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants