Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Sentry.IO Error Reporting (or alternatively, non-automated 'upload error' button) #371

Open
shasheene opened this issue Aug 28, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@shasheene
Copy link
Member

shasheene commented Aug 28, 2022

Sentry.IO provides a free web-interface and SDK to detect when Python exceptions happen.

The official Ubuntu repository has the python3-sentry-sdk package already present.

The error reports will help quickly learn about issues like #352.

Related: I need to write a privacy document #340, because automated error reporting using Sentry.IO's open-source SDK is still a change to Rescuezilla privacy.

Feel free to post below if you feel strongly against integrating "Sentry.IO" automated error reporting. I think it provides a good balance of improved Rescuezilla stability vs privacy.

@shasheene shasheene added the enhancement New feature or request label Aug 28, 2022
@shasheene shasheene self-assigned this Aug 28, 2022
@CryptGoat
Copy link

CryptGoat commented Aug 30, 2022

I understand the desire for more data to get a quick grip to identify and fix problems of Rescuezilla but I feel strongly negative about automated error reporting. Many Linux distributions and also Rescuezilla are highly regarded and widely used by users who value their privacy. Pretty much no Linux distribution does send data about the system by default and if they did at some point it always backfired big in their respective community. Not even Apport in Ubuntu does send crash reports by itself. Also, Sentry is third party US based company. Not sure if I want them to handle my system data (yes, I know Sentry is widely used and I'm writing this on MS owned GitHub right now).

Distribute Rescuezilla for Backup purposes on USB flash drives at privacy events and there's no way I include this if it sends data about the user's device by default. If you still decide to include error reporting please make it at-least entirely opt-in and make that choice and the info sent as transparent as possible. Selfhosting the sentry server should also be considered.

Also, if you still plan to include this it might be better to spent some time thinking about this and – if still deemed necessary – integrate it with the next major release instead of a release which was originally ment to fix some major bugs? Really looking forward to that version 2.4.1... 😉

@shasheene
Copy link
Member Author

Yep, good argument for not including it in v2.4.1.

And also good argument against enabled by default in Rescuezilla.

What about a checkbox on the initial "Welcome" page of Rescuezilla that reads something like "Automatically upload error details"? It could be left unticked by default. Then users having trouble would have to decide to go back and tick the box and reproduce the error. Still an improvement on what I currently have.

Another approach is a button or checkbox on the error message box that uploads the details. That would work, but it won't catch the places that don't currently generate an error box.

@shasheene shasheene changed the title Integrate Sentry.IO Error Reporting Integrate Sentry.IO Error Reporting (or alternatively, non-automated 'upload error' button) Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants