Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you provide training log? #17

Closed
oubathAI opened this issue Oct 9, 2020 · 5 comments
Closed

Can you provide training log? #17

oubathAI opened this issue Oct 9, 2020 · 5 comments

Comments

@oubathAI
Copy link

oubathAI commented Oct 9, 2020

Hi,

First of all I wanted to thank you for your work, the code is rather clean, easy to read and well structured, just like the paper. Good job!
I am trying to write this model using Tensorflow.
I would have liked to have the training log file (train.log); to make sure that the losses I get are consistent.
I used the loss weights you specified in the repository; and I have after 20 epochs:
reconstruction_loss: 0.0897 - transferal_perceptual_loss: 1.1900 - d_loss: -30.2180 - psnr: 25.3971 - ssim: 0.6679 - perceptual_loss: 47.2544 - adversarial_loss: 0.0534 - total_loss: 48.5875
As you can see the losses are not at all in the same value range; and since the perceptual loss represents more than 97% of the total loss, I doubt that the other losses will have a real impact during training; especially the adversarial_loss which has a factor of 1e3 with the perceptual loss.
It would just be great if you could log your training so that I can adjust the loss weights accordingly to do the same training with Tensorflow.

Thank you very much,

@FuzhiYang
Copy link
Member

I re-ran my code just now, and I took some screenshots of the training log:
image
image
image

You can refer the above screenshots to adjust the loss weights.

From my experience of TensorFlow, there may be some differences in internal implementation between PyTorch and TensorFlow. Therefore, the loss weights may be different, which needs to be adjusted carefully.

@oubathAI
Copy link
Author

Thanks for your reply. I will adjust the losses accordingly and see if it trains better.

@MiotyR
Copy link

MiotyR commented Oct 16, 2020

Hi,

Thanks for providing the screenshots of your training.

I was wondering if you can provide the training log of the discriminator. I would like to compare with your values because I monitor it also.

Thank you in advance,

@oubathAI
Copy link
Author

@MiotyR yes you're right, it would be really useful to have the d_loss too.
Mine's at -5 right now, and I have no idea if that's good or not.
@FuzhiYang Can you provide the d_loss too? And if it's too complicated to make screenshots, you can give us the log file and we'll get the information by ourselves. It'll be easier for you I think.

@FuzhiYang
Copy link
Member

I didnot record d_loss in the log. You can add d_loss into the log in my code for your reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants