Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The PSNR on Urban100 is different from the paper? #6

Closed
yangfan97 opened this issue Jul 12, 2020 · 3 comments
Closed

The PSNR on Urban100 is different from the paper? #6

yangfan97 opened this issue Jul 12, 2020 · 3 comments

Comments

@yangfan97
Copy link

Thank you for your sharing! I have trained RCAN on the CUFED5 training set, and the PSNR I got on Urban100 is 26.15dB. In the paper, the PSNR on Urban100 of RCAN is 25.42dB. When I was training RCAN, I just followed the setting in SRNTT. Maybe there are still some differences between our setting. Could you please tell me your detailed setting for training RCAN?

@FuzhiYang
Copy link
Member

Thank you for your interest in our work! Although I cannot remember all the training details when training RCAN since it has been a long time passed, there are some important details that may help you:

  1. Following the setting of SRNTT, we use scipy.misc.imresize to apply bicubic interpolation for LR generation. Please note: this function has been depreciated in SciPy 1.0.0, and was removed in 1.3.0. You can use PIL's resize function instead as in our code. Matlab's imresize which has unique antialias is not adopted here.
  2. The metrics PSNR and SSIM are evaluated on Y-channel in YCbCr image.
  3. When training RCAN_x4, there is no pre-training on RCAN_x2 to ensure fair comparison.

Also, different initialization and training bias will influence the final results. Besides, there may be other training details that are not listed here or what we cannot remember. By the way, from our experimental experience, the backbone of recent RefSR methods such as TTSR, SRNTT, etc is not optimal, where a progressive upsampling architecture with ResBlocks applied. It is encouraged that you can try more possible effective backbones such as RCAN, etc that have an architecture with only the last few layers to upsample.

@tejaskhot
Copy link

Hi @FuzhiYang !
It looks like the code used for computing PSNR is using all channels of the image and not just Y.

@FuzhiYang
Copy link
Member

Hi @tejaskhot
Both PSNR and SSIM are calculated on Y channel in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants