Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint dependencies should be dev dependencies #1390

Open
checkerschaf opened this issue Mar 29, 2024 · 0 comments
Open

Eslint dependencies should be dev dependencies #1390

checkerschaf opened this issue Mar 29, 2024 · 0 comments
Labels
Package: react-email This is the CLI we generally use as just `email` on the temrinal. Type: Bug Confirmed bug

Comments

@checkerschaf
Copy link

checkerschaf commented Mar 29, 2024

Describe the Bug

I think eslint packages should be a dev dependency so that they do not get installed if the user does not use eslint as a linter.

Link to the package.json:

"eslint-config-prettier": "9.0.0",
"eslint-config-turbo": "1.10.12",

Which package is affected (leave empty if unsure)

react-email

Link to the code that reproduces this issue

"eslint-config-prettier": "9.0.0",
"eslint-config-turbo": "1.10.12",

To Reproduce

Install the react-email in a repository without eslint as a peer-dependency.

Expected Behavior

No eslint packages should be installed in the package-lock.json file.

What's your node version? (if relevant)

No response

@checkerschaf checkerschaf added the Type: Bug Confirmed bug label Mar 29, 2024
@gabrielmfern gabrielmfern added the Package: react-email This is the CLI we generally use as just `email` on the temrinal. label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: react-email This is the CLI we generally use as just `email` on the temrinal. Type: Bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

2 participants