Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on main site missing @react-email/components from install #1501

Closed
j-mcgregor opened this issue Jun 11, 2024 · 5 comments
Closed
Labels
Type: Bug Confirmed bug Type: Documentation Improvements or additions to documentation

Comments

@j-mcgregor
Copy link

Describe the Bug

Title sums it up but you're missing the @react-email/components from the install line and the very next step requires it but it won't be installed.

image

Which package is affected (leave empty if unsure)

@react-email/components

Link to the code that reproduces this issue

https://react.email/docs/integrations/postmark

To Reproduce

Literally follow the steps on the guide -> https://react.email/docs/integrations/postmark

Expected Behavior

Step 2 shouldn't show any errors as everything will be installed

What's your node version? (if relevant)

20

@j-mcgregor j-mcgregor added the Type: Bug Confirmed bug label Jun 11, 2024
@gabrielmfern
Copy link
Collaborator

Thanks for pointing this out, seems like the other guides for integration also have this issue.

@gabrielmfern gabrielmfern added the Type: Documentation Improvements or additions to documentation label Jun 11, 2024
@7H3XXX
Copy link
Contributor

7H3XXX commented Jun 18, 2024

Hello, since the changes suggested by @j-mcgregor are not already made, can I make a PR that solves it ?

@gabrielmfern
Copy link
Collaborator

@7H3XXX Certainly feel free to do it.

@7H3XXX
Copy link
Contributor

7H3XXX commented Jun 19, 2024

@gabrielmfern I also noticed a missing dependency in the plunk integration (@react-email/render), I went ahead and added it.

@gabrielmfern
Copy link
Collaborator

This was fixed by #1509 and should be correct now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Confirmed bug Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants