Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some missing lines on Voronoi #9

Closed
asoifer opened this issue Aug 17, 2021 · 4 comments
Closed

Some missing lines on Voronoi #9

asoifer opened this issue Aug 17, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@asoifer
Copy link

asoifer commented Aug 17, 2021

Hi,
I'm using the Olden's benchmark (with recursive programs) for playing with the tool.
I chose Voronoi with the arguments "-n 9", and the line with the println invocation as criterion.

The problem is that there are 2 sliced lines in the output, the line with println and the slicingVariable1B declaration.
If I try with -n 2 it works!
If I try with -n 3 it doesn't work (and it's not producing the output I don't know why)
If I try with -n 9 it works returning only 2 lines.
I think the problem is on recursion, but I'm know that is too hard to find these issues... (and if there are issues...)

Vertex.seed = 1023;
Vertex extra = Vertex.createPoints(1, new MyDouble(1.0), points);
Vertex point = Vertex.createPoints(points-1, new MyDouble(extra.X()), points-1);

Edge edge = point.buildDelaunayTriangulation(extra);

Edge slicingVariable1 = edge;
// This is the only line in the slice, and slicingVariable1 is not null
Boolean slicingVariable1B = (slicingVariable1 != null);
Edge[] slicingVariable2 = edge.quadList;
Edge slicingVariable3 = edge.quadList[0];
int slicingVariable4 = edge.listPos;
Vertex slicingVariable5 = edge.vertex;
Edge slicingVariable6 = edge.next;

System.out.println(slicingVariable1B); // I'm slicing this line

I'm attaching the source code and the output (including the trace), except the jars.
Voronoi.zip

Thank you so much in advance,
Alexis.

@khaled-e-a khaled-e-a self-assigned this Aug 17, 2021
@khaled-e-a khaled-e-a added the bug Something isn't working label Aug 17, 2021
@khaled-e-a
Copy link
Collaborator

Quick update: still working on this, progress slowed down due to other commitments.

@asoifer
Copy link
Author

asoifer commented Aug 29, 2021

Thanks for the update! :)

@khaled-e-a
Copy link
Collaborator

This is fixed in the latest commits in DynamicSlicingCore and Slicer4J. The slice is much more than 2 lines now. As I don't have a ground truth, I am closing this issue. Please re-open if slice is missing lines.

@asoifer
Copy link
Author

asoifer commented Sep 20, 2021

Hi Khaled, thanks for your commits and I'm sorry for the late reply.
I tried to re-run Voronoi and I'm still watching 2 lines. I checked that I pull and reinstall each library (Core and Slicer).
For example, with this sub program (extracted from Voronoi):

Edge edge = point.buildDelaunayTriangulation(extra);
Edge slicingVariable1 = edge;
Boolean slicingVariable1B = (slicingVariable1 != null);
System.out.println(slicingVariable1B);

When I slice from the last line, I'm only getting the last 2 lines, not the first two.
I don't know if I'm doing something wrong but it always exists the possibility.

When I have more time, I'll try again this and using it in more examples.
Thanks again,
Alexis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants