Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

GRIM: Manny disappears when entering Toto's building #648

Closed
tobigun opened this issue Aug 25, 2012 · 4 comments
Closed

GRIM: Manny disappears when entering Toto's building #648

tobigun opened this issue Aug 25, 2012 · 4 comments

Comments

@tobigun
Copy link
Contributor

tobigun commented Aug 25, 2012

When entering Toto's building, Manny is not visible anymore. He can neither perform any action nor leave the building. If the arrow keys are pressed the scene switches from time to time to the room with the fridge.

This bug was introduced with commit c9b33fc, "GRIM: Fix an error with patchr instead of detecting it later". Removing "lua_error("Bad argument to start_script");" in start_script(), ltask.cpp fixes this problem. Either the patchr patch is not correctly applied or there are more positions in the lua code that pass bad arguments to start_script().

@somaen
Copy link
Member

somaen commented Dec 17, 2012

Does this happen if you just skip to the set, or play from the start?

@giucam
Copy link
Contributor

giucam commented Dec 17, 2012

I think the problem is that the savegame was made before the fixing of the lua script. So you have the old bugged script and the c++ code that doesn't let it pass anymore.

@tobigun
Copy link
Contributor Author

tobigun commented Dec 18, 2012

It is like giucam said. The script was changed by the patchr. But as I used a savegame, the old scripts embedded in the savegame were used. See #649.

The script fix prevents that bad arguments are passed to start_script() and so lua_error() was enabled again, which works fine with patched scripts - but not with old scripts in a savegame.

@klusark
Copy link
Member

klusark commented Mar 30, 2014

Closed as #649 supersedes this.

@klusark klusark closed this as completed Mar 30, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants