Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CircuitBreakerRegistry registed CircuitBreaker can't not update #282

Closed
yanickxia opened this issue Oct 31, 2018 · 0 comments
Closed

CircuitBreakerRegistry registed CircuitBreaker can't not update #282

yanickxia opened this issue Oct 31, 2018 · 0 comments
Assignees
@RobWin
Labels
enhancement implemented
Projects
Release 0.15.0
Milestone
0.15.0

Comments

@yanickxia
Copy link

if want to update a CircuitBreaker in CircuitBreakerRegistry, not good way to done it...

circuitBreakers.computeIfAbsent(Objects.requireNonNull(name, "Name must not be null"), (k) -> CircuitBreaker.of(name,
                customCircuitBreakerConfig));

maybe add a fouces replace method
@storozhukBM storozhukBM added this to the 0.14.0 milestone Nov 29, 2018
@RobWin RobWin modified the milestones: 0.14.0, 0.150 Mar 22, 2019
@RobWin RobWin added this to the 0.15.0 milestone Apr 26, 2019
@RobWin RobWin self-assigned this Apr 26, 2019
@RobWin RobWin added this to In progress in Release 0.15.0 Apr 26, 2019
@RobWin RobWin moved this from In progress to Done in Release 0.15.0 Apr 30, 2019
@RobWin RobWin closed this as completed May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobWin RobWin

Labels
enhancement implemented
Projects
No open projects
Release 0.15.0
  
Done
Milestone
0.15.0
Development

No branches or pull requests
3 participants
@storozhukBM @RobWin @yanickxia