New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency with GST Transporter ID #2072

Closed

ljain112 opened this issue Apr 26, 2024 · 0 comments · Fixed by #2198

Collaborator

ljain112 commented Apr 26, 2024

Frappe Support Issue: https://support.frappe.io/app/hd-ticket/13855

Eg Transporter ID: 29AAFCA7488L1Z0
This is a valid transporter ID but Invalid GSTIN and check digit validation is failing.

Proposed Solution

Avoid check digit validation for all transporter ID and only validate GSTIN regex
Use directly transporter ID API for all the gstin with transporter or Remove transporter validation at all.

vishakhdesai mentioned this issue

revert: GST Transporter ID API validation (refactor and fixes required) #2080

Closed

ljain112 linked a pull request

that will close this issue

fix: GST Transporter ID Refactor #2198

Merged

vorasmit closed this as completed in #2198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment