Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev UX tweaks #34

Merged
merged 5 commits into from Aug 28, 2017
Merged

Dev UX tweaks #34

merged 5 commits into from Aug 28, 2017

Conversation

pimterry
Copy link
Contributor

@pimterry pimterry commented Aug 24, 2017

Some independent dev process tweaks, extracted separately from the rest of my changes. These mean that now:

  • Versionbot will autodeploy to npm
  • npm run build builds, but doesn't run the tests (while npm test builds then runs the tests) - this is useful for upcoming node-gyp additions - EDIT: I've now actually just removed Gulp entirely, since plain npm scripts actually makes this process (and future changes) quite a bit simpler
  • npm install doesn't run the full test suite - only npm publish does

@pimterry pimterry requested a review from hedss August 24, 2017 14:23
Copy link
Contributor

@hedss hedss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Versionbot will autodeploy to npm" - \o/

Looks fantastic to me. Removing gulp is def. a good call.

At some point, we'll need to move this over to Circle, but given there are still potential issues with secrets, I'm in no rush.

Thanks for this!

@resin-io-modules-versionbot resin-io-modules-versionbot bot merged commit 71fd41b into master Aug 28, 2017
@resin-io-modules-versionbot
Copy link

VersionBot failed to carry out a status check for the above pull request here: #34. The reason for this is:
Reference already exists
Please carry out relevant changes or alert an appropriate admin.

@pimterry pimterry deleted the dev-ux-fixes branch August 28, 2017 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants