Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResinBuildNotFound error #15

Merged
merged 3 commits into from Mar 8, 2017
Merged

Add ResinBuildNotFound error #15

merged 3 commits into from Mar 8, 2017

Conversation

pimterry
Copy link
Contributor

@pimterry pimterry commented Mar 8, 2017

I'm adding individual build lookup to the SDK as part of https://github.com/resin-io/resin-ui/issues/400, since it's required in the UI. We've got errors to represent missing applications and devices, but not builds - this bring them into line.

@pimterry
Copy link
Contributor Author

pimterry commented Mar 8, 2017

Tests failed because:

  • Saucelabs failed to start an Edge for us. This has happened before, maybe our saucelabs setup is broken? Ignoring for now, since the other builds pass.
  • The version of NPM we use isn't supported on the old versions of Node we're using. I've pushed a bonus change to move this module to testing only against 4+, in line with the SDK.

@@ -18,7 +18,7 @@ limitations under the License.
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add header: true to the coffee build config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, done.

@pimterry pimterry merged commit bbcbed1 into master Mar 8, 2017
@pimterry pimterry deleted the build-not-found branch March 8, 2017 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants