fix(GUI): don't split robot input by new lines inside properties #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've recently PRed a commit that handles multiple IPC messages being triggered at the same time, confusing `JSON.parse()`. As a solution to such problem, we are splitting the CLI output on new lines, based on the assumption that each line represents a different object, however we didn't consider that in the case of errors, we include an `stacktrace` property which usually includes new line characters, causing such information to be completely garbled and cause `JSON.parse()` once again to get confused. As a solution, we only split by new lines that are not surrounded by quotes (since they represent a JSON property). See: #997 Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
jviotti
force-pushed
the
lines-split-nested-new-lines
branch
from
782433d
to
5c388e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently PRed a commit that handles multiple IPC messages being
triggered at the same time, confusing
JSON.parse(). As a solution tosuch problem, we are splitting the CLI output on new lines, based on the
assumption that each line represents a different object, however we
didn't consider that in the case of errors, we include an
stacktraceproperty which usually includes new line characters, causing such
information to be completely garbled and cause
JSON.parse()once againto get confused.
As a solution, we only split by new lines that are not surrounded by
quotes (since they represent a JSON property).
See: #997
Signed-off-by: Juan Cruz Viotti jviotti@openmailbox.org