fix(GUI): multiple JSON objects coming up at once from the IPC client #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviotti
force-pushed
the
fix-multiple-json-ipc
branch
2 times, most recently
from
101e8ac
to
c5c672c
Compare
The GUI executes the CLI and pipes every line of output coming from either `stdout` or `stderr` to the IPC server as "messages." In some scenarios, the child process data handler might receive multiple lines of output at the same time. Since the CLI outputs stringified JSON objects each in a different line, trying to parse two JSON objects separated by a new line causes the parser to crash. As a solution, we split the data coming in by new lines (`\r\n` in Windows), and emit a message for only the last one. Fixes: #898 Changelog-Entry: Fix "Invalid message" error caused by the IPC client emitting multiple JSON objects as a single message. Change-Type: patch Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
jviotti
force-pushed
the
fix-multiple-json-ipc
branch
from
c5c672c
to
843cfab
Compare
jviotti
pushed a commit
that referenced
this pull request
Jan 9, 2017
We've recently PRed a commit that handles multiple IPC messages being triggered at the same time, confusing `JSON.parse()`. As a solution to such problem, we are splitting the CLI output on new lines, based on the assumption that each line represents a different object, however we didn't consider that in the case of errors, we include an `stacktrace` property which usually includes new line characters, causing such information to be completely garbled and cause `JSON.parse()` once again to get confused. As a solution, we only split by new lines that are not surrounded by quotes (since they represent a JSON property). See: #997 Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
jviotti
pushed a commit
that referenced
this pull request
Jan 9, 2017
We've recently PRed a commit that handles multiple IPC messages being triggered at the same time, confusing `JSON.parse()`. As a solution to such problem, we are splitting the CLI output on new lines, based on the assumption that each line represents a different object, however we didn't consider that in the case of errors, we include an `stacktrace` property which usually includes new line characters, causing such information to be completely garbled and cause `JSON.parse()` once again to get confused. As a solution, we only split by new lines that are not surrounded by quotes (since they represent a JSON property). See: #997 Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
jviotti
pushed a commit
that referenced
this pull request
Jan 10, 2017
We've recently PRed a commit that handles multiple IPC messages being triggered at the same time, confusing `JSON.parse()`. As a solution to such problem, we are splitting the CLI output on new lines, based on the assumption that each line represents a different object, however we didn't consider that in the case of errors, we include an `stacktrace` property which usually includes new line characters, causing such information to be completely garbled and cause `JSON.parse()` once again to get confused. As a solution, we only split by new lines that are not surrounded by quotes (since they represent a JSON property). See: #997 Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GUI executes the CLI and pipes every line of output coming from
either
stdoutorstderrto the IPC server as "messages."In some scenarios, the child process data handler might receive multiple
lines of output at the same time. Since the CLI outputs stringified JSON
objects each in a different line, trying to parse two JSON objects
separated by a new line causes the parser to crash.
As a solution, we split the data coming in by new lines (
\r\ninWindows), and emit a message for only the last one.
Fixes: #898
Changelog-Entry: Fix "Invalid message" error caused by the IPC client emitting multiple JSON objects as a single message.
Change-Type: patch
Signed-off-by: Juan Cruz Viotti jviotti@openmailbox.org