Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to use a non-existent lodash instance #285

Merged
merged 1 commit into from Mar 17, 2017
Merged

Don't try to use a non-existent lodash instance #285

merged 1 commit into from Mar 17, 2017

Conversation

pimterry
Copy link
Contributor

These two functions are untested (because we don't have any tests for parts of the SDK that require real live devices), and still depended on _ being available, although it was removed many months ago as part of the move to add browser support.

This fixes balena-io/balena-cli#449.

@pimterry pimterry requested a review from emirotin March 17, 2017 15:09
@pimterry pimterry mentioned this pull request Mar 17, 2017
Closed
emirotin
emirotin approved these changes Mar 17, 2017
View reviewed changes
Copy link
Contributor

@emirotin emirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Looks like I have clearly missed them when making the conversion, though I have no idea how that was possible.

@pimterry pimterry merged commit 4cabd32 into master Mar 17, 2017
@pimterry pimterry deleted the fix-cli-lodash-bug branch March 17, 2017 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emirotin emirotin emirotin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The shutdown and reboot device commands do not work
2 participants
@pimterry @emirotin