Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the supervisor is interrupted while running migrations, knex can leave a leftover lock #598

Closed
pcarranzav opened this issue Mar 21, 2018 · 1 comment
Closed

If the supervisor is interrupted while running migrations, knex can leave a leftover lock #598

pcarranzav opened this issue Mar 21, 2018 · 1 comment
Assignees
@pcarranzav

Comments

@pcarranzav
Copy link
Contributor

After starting again, supervisor logs show:

 [2018-03-21T09:31:56.652Z] Knex:warning - Can't take lock to run migrations: Migration table is already locked
 [2018-03-21T09:31:56.662Z] Knex:warning - If you are sure migrations are not running you can release the lock manually by deleting all the rows from migrations lock table: knex_migrations_lock
 [2018-03-21T09:31:56.672Z] Unhandled rejection MigrationLocked: Migration table is already locked

Connects-to: https://github.com/resin-io/hq/issues/1256
@pcarranzav pcarranzav self-assigned this Mar 21, 2018
pcarranzav pushed a commit that referenced this issue Mar 21, 2018
Remove any leftover knex migrations locks before running migrations
86803c6 
Closes #598
Change-Type: patch
Signed-off-by: Pablo Carranza Velez <pablo@resin.io>
@ghost ghost added the flow/in-progress label Mar 21, 2018
@pcarranzav pcarranzav mentioned this issue Mar 21, 2018
Merged
@ghost ghost added flow/in-review and removed flow/in-progress labels Mar 21, 2018
pcarranzav pushed a commit that referenced this issue Mar 21, 2018
Remove any leftover knex migrations locks before running migrations
c8d79c3 
Closes #598
Change-Type: patch
Signed-off-by: Pablo Carranza Velez <pablo@resin.io>
@ghost ghost closed this as completed in #599 Mar 22, 2018
@ghost ghost removed the flow/in-review label Mar 22, 2018
@jellyfish-bot
Copy link

[saintaardvark] This issue has attached support thread https://jel.ly.fish/1ebddba8-88f5-418f-bfd0-6553b9543d04

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcarranzav pcarranzav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pcarranzav @robertgzr @jellyfish-bot