Skip to content

Commit

Permalink
name change for connect(..) param in reTurn; is_v6 -> allowV6
Browse files Browse the repository at this point in the history
  • Loading branch information
Jeremy Geras committed May 9, 2013
1 parent 4a68f9f commit f5754d3
Show file tree
Hide file tree
Showing 11 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion reTurn/AsyncSocketBase.hxx
Expand Up @@ -30,7 +30,7 @@ public:

/// Note: The following API's are thread safe and queue the request to be handled by the ioService thread
virtual asio::error_code bind(const asio::ip::address& address, unsigned short port) = 0;
virtual void connect(const std::string& address, unsigned short port, bool is_v6) = 0;
virtual void connect(const std::string& address, unsigned short port, bool allowV6) = 0;
/// Note: destination is ignored for TCP and TLS connections
virtual void send(const StunTuple& destination, boost::shared_ptr<DataBuffer>& data); // Send unframed data
virtual void send(const StunTuple& destination, unsigned short channel, boost::shared_ptr<DataBuffer>& data); // send with turn framing
Expand Down
2 changes: 1 addition & 1 deletion reTurn/AsyncTcpSocketBase.cxx
Expand Up @@ -47,7 +47,7 @@ AsyncTcpSocketBase::bind(const asio::ip::address& address, unsigned short port)
}

void
AsyncTcpSocketBase::connect(const std::string& address, unsigned short port, bool is_v6)
AsyncTcpSocketBase::connect(const std::string& address, unsigned short port, bool allowV6)
{
// Start an asynchronous resolve to translate the address
// into a list of endpoints.
Expand Down
2 changes: 1 addition & 1 deletion reTurn/AsyncTcpSocketBase.hxx
Expand Up @@ -17,7 +17,7 @@ public:
virtual unsigned int getSocketDescriptor();

virtual asio::error_code bind(const asio::ip::address& address, unsigned short port);
virtual void connect(const std::string& address, unsigned short port, bool is_v6);
virtual void connect(const std::string& address, unsigned short port, bool allowV6);

virtual void transportReceive();
virtual void transportFramedReceive();
Expand Down
2 changes: 1 addition & 1 deletion reTurn/AsyncTlsSocketBase.cxx
Expand Up @@ -54,7 +54,7 @@ AsyncTlsSocketBase::bind(const asio::ip::address& address, unsigned short port)
}

void
AsyncTlsSocketBase::connect(const std::string& address, unsigned short port, bool is_v6)
AsyncTlsSocketBase::connect(const std::string& address, unsigned short port, bool allowV6)
{
mHostname = address;

Expand Down
2 changes: 1 addition & 1 deletion reTurn/AsyncTlsSocketBase.hxx
Expand Up @@ -24,7 +24,7 @@ public:
virtual unsigned int getSocketDescriptor();

virtual asio::error_code bind(const asio::ip::address& address, unsigned short port);
virtual void connect(const std::string& address, unsigned short port, bool is_v6);
virtual void connect(const std::string& address, unsigned short port, bool allowV6);

void doHandshake();

Expand Down
4 changes: 2 additions & 2 deletions reTurn/AsyncUdpSocketBase.cxx
Expand Up @@ -44,13 +44,13 @@ AsyncUdpSocketBase::bind(const asio::ip::address& address, unsigned short port)
}

void
AsyncUdpSocketBase::connect(const std::string& address, unsigned short port, bool is_v6)
AsyncUdpSocketBase::connect(const std::string& address, unsigned short port, bool allowV6)
{
// Start an asynchronous resolve to translate the address
// into a list of endpoints.
resip::Data service(port);
#ifdef USE_IPV6
asio::ip::udp::resolver::query query((is_v6 ? asio::ip::udp::v6() : asio::ip::udp::v4()), address, service.c_str());
asio::ip::udp::resolver::query query((allowV6 ? asio::ip::udp::v6() : asio::ip::udp::v4()), address, service.c_str());
#else
asio::ip::udp::resolver::query query(asio::ip::udp::v4(), address, service.c_str());
#endif
Expand Down
2 changes: 1 addition & 1 deletion reTurn/AsyncUdpSocketBase.hxx
Expand Up @@ -17,7 +17,7 @@ public:
virtual unsigned int getSocketDescriptor();

virtual asio::error_code bind(const asio::ip::address& address, unsigned short port);
virtual void connect(const std::string& address, unsigned short port, bool is_v6);
virtual void connect(const std::string& address, unsigned short port, bool allowV6);

virtual void transportReceive();
virtual void transportFramedReceive();
Expand Down
4 changes: 2 additions & 2 deletions reTurn/client/TurnAsyncSocket.cxx
Expand Up @@ -1100,9 +1100,9 @@ TurnAsyncSocket::sendToRemotePeer(RemotePeer& remotePeer, boost::shared_ptr<Data
}

void
TurnAsyncSocket::connect(const std::string& address, unsigned short port, bool is_v6)
TurnAsyncSocket::connect(const std::string& address, unsigned short port, bool allowV6)
{
mAsyncSocketBase.connect(address, port, is_v6);
mAsyncSocketBase.connect(address, port, allowV6);
}

void
Expand Down
2 changes: 1 addition & 1 deletion reTurn/client/TurnAsyncSocket.hxx
Expand Up @@ -58,7 +58,7 @@ public:
// Sets the local HmacKey, used to check the integrity of incoming STUN messages
void setLocalPassword(const char* password);

void connect(const std::string& address, unsigned short port, bool is_v6);
void connect(const std::string& address, unsigned short port, bool allowV6);

// Stun Binding Method - use getReflexiveTuple() to get binding info
void bindRequest();
Expand Down
2 changes: 1 addition & 1 deletion reTurn/client/test/TestAsyncClient.cxx
Expand Up @@ -293,7 +293,7 @@ int main(int argc, char* argv[])
handler.setTurnAsyncSocket(turnSocket.get());

// Connect to Stun/Turn Server
turnSocket->connect(argv[1], port);
turnSocket->connect(argv[1], port, false);

// Set the username and password
turnSocket->setUsernameAndPassword(username, password);
Expand Down
2 changes: 1 addition & 1 deletion reTurn/client/test/TestRtpLoad.cxx
Expand Up @@ -368,7 +368,7 @@ int main(int argc, char* argv[])
handler.setTurnAsyncSocket(turnSocket.get());

// Connect to Stun/Turn Server
turnSocket->connect(turnAddress.c_str(), port);
turnSocket->connect(turnAddress.c_str(), port, false);

// Set the username and password
turnSocket->setUsernameAndPassword(username, password);
Expand Down

0 comments on commit f5754d3

Please sign in to comment.