Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance of resque-pool #109

Open
spajus opened this issue Mar 19, 2014 · 17 comments
Open

Maintenance of resque-pool #109

spajus opened this issue Mar 19, 2014 · 17 comments

Comments

@spajus
Copy link
Contributor

spajus commented Mar 19, 2014

@nevans, it seems like resque-pool has plenty of pull requests and issues that are ignored for quite a long time. Would you like to give somebody rights to maintain the repository and release gem updates? I'm using resque-pool heavily, so I would be willing to help maintain it. Possibly somebody else would too.

@wollkind
Copy link

As someone with a couple of open issues that haven't even been commented on yet, I'm all in favor of this. I probably don't have a lot of time to help maintain, but I'm happy keep reporting on issues and give my best guess for fixing them as they come up in my work if it looks like they'll get addressed.

@raphaelcm
Copy link

+1

resque-pool as it currently stands is a great start, but could really use some TLC.

@oesgalha
Copy link

+1

@spajus
Copy link
Contributor Author

spajus commented Apr 28, 2014

I've tried to email @nevans to no avail. I'm thinking of starting a fork and maintaining resque-pool over there.

@raphaelcm
Copy link

@spajus go for it. would love to see this project actively maintained. thanks for spearheading this!

@spajus
Copy link
Contributor Author

spajus commented Apr 28, 2014

Forked it to Vinted organization: https://github.com/vinted/resque-pool
Will start applying old PRs and preparing new gem some time soon. I hopefully won't be alone maintaining it there.

@nevans
Copy link
Collaborator

nevans commented Apr 29, 2014

Tomas (et al), sorry I've been so neglectful. If we discuss (and document in README.md or CONTRIBUTERS.md) commit, merge, and release policy, then I will be comfortable giving commit rights to this repo (or pointing folks to an organization's repo, e.g. vinted) and rubygems co-ownership.

My $0.02:

  1. We should commit to semantic versioning.
  2. We should be conservative with releases, which simply means that:
    • tests pass
    • a new release shouldn't be cut until one or more of the maintainers has been running the latest RC in production for a week with no critical bugs.

What do you think?

(As another point of interest, there is also a new project https://github.com/spraints/resqued that does much of what resque-pool does, but with slightly newer cleaner codebase. Only one committer so far, and github doesn't seem to have advertised it much, but I think they are using it in production.)

@spajus
Copy link
Contributor Author

spajus commented Apr 29, 2014

@nevans, thanks for response 🙇, I'm relieved that we won't have to live with that fork.
Your suggestions sound good. Might need little more details on how to deal with PRs. Will submit a proposal for CONTRIBUTING.md some time later this week, unless someone else does it first.

As of resqued, may be a nice project, but resque-pool is battle tested, and migrating our job farms to something else that has considerably smaller community would be risky and challenging.

@darkness51
Copy link

@nevans @spajus something new about new version?

@spajus
Copy link
Contributor Author

spajus commented Oct 14, 2014

@darkness51 I got bogged down with other things and didn't find the time to prepare a proposal for CONTRIBUTING.md, so everything got covered in dust in here. It would be nice to continue this though. Perhaps somebody else would like to help?

@spajus
Copy link
Contributor Author

spajus commented Jan 28, 2015

👍 @zmillman for stepping in

@spajus spajus closed this as completed Jan 28, 2015
@nevans
Copy link
Collaborator

nevans commented Jan 28, 2015

We have a first pass CONTRIBUTING.md, but we still don't have anyone other than me pushing gems. I don't think this ticket should be closed until I have either proven myself to not be a negligent maintainer or have given several other folks gem push rights. :)

@nevans nevans reopened this Jan 28, 2015
@spajus
Copy link
Contributor Author

spajus commented Jan 28, 2015

Yep, good point... :)

@nevans
Copy link
Collaborator

nevans commented Jan 28, 2015

FYI: since lots of folks have been using 0.4.0.rc2 (or a fork based on that) for over a year, clearly it was just time to SHIP IT! So I did. 0.4.0.rc2 was promoted to 0.4.0. :shipit:

I also pushed 0.5.0.rc1 (which is based on 0.4.0.rc3 plus a bugfix for resque-multi-jobs-fork). If you want to help me with maintaining resque-pool, please try it out now. 😄

@nevans nevans closed this as completed Jan 28, 2015
@nevans nevans reopened this Jan 28, 2015
@nevans
Copy link
Collaborator

nevans commented Jan 29, 2015

If you want to help with maintenance, here's another thing you can do: check out #120 and provide input there. Specifically, I want to analyze the long-lived branches to see which ones need support before semver 1.0.0, so we can support them without releasing 2.0.0.

@nevans
Copy link
Collaborator

nevans commented Oct 5, 2015

Please test out the 0.6.0-rc1; big new custom config loader feature.

@michaelglass
Copy link

@nevans any progress here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants