Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resque-pool 0.5.0 broke resque:work rake task #124

Open
kovyrin opened this issue Jun 26, 2015 · 1 comment
Open

resque-pool 0.5.0 broke resque:work rake task #124

kovyrin opened this issue Jun 26, 2015 · 1 comment

Comments

@kovyrin
Copy link

kovyrin commented Jun 26, 2015

Hey guys,

I'm not sure if that was intentional, but resque-pool 0.5.0 (specifically, this commit: 2f91e91) changed the way shutdown? method works and now there is no way to run rake resque:work without resque pool - it just exits immediately upon exiting the main processing loop (since there are no parent pids registered by resque-pool).

Basically, this means that by simply including resque-pool in a Gemfile of a project one loses ability to use resque without executing the resque-pool command.

@nevans
Copy link
Collaborator

nevans commented Jun 30, 2015

Not intentional. It was meant to fix a problem with running resque-pool inside docker. I think that you should be able to temporarily workaround this by telling the Gemfile to require: nil so it doesn't get automatically loaded, and then explicitly require it from the rake task (resque:pool) or just use the command line bin/resque-pool.

A fix would be as simple as checking to see if either of the two pids have been set, and if neither have then default to normal behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants