Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement versioning using commit hash #3

Open
lobis opened this issue Mar 17, 2021 · 2 comments
Open

Implement versioning using commit hash #3

lobis opened this issue Mar 17, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@lobis
Copy link
Member

lobis commented Mar 17, 2021

Right now versioning is using a version file which contains a string of the form 0.0.1. On each execution of the materials.py script this version is increased and included into the xml version tag.

We should define an additional tag (commit?) to store the commit hash information into the generated materials.xml. This could probably be done using git hooks.

Relevant discussion: http://ezpc10.unizar.es/t/important-material-repository-updates/460/12

@lobis lobis added enhancement New feature or request help wanted Extra attention is needed labels Mar 17, 2021
@jgalan
Copy link
Member

jgalan commented Mar 17, 2021

However, there might be material files that are managed manually. They will also be automatically stamped with a version?

I believe, for the particular case of restG4 you could just integrate that at TRestGDMLParser, reading it from https://sultan.unizar.es/materials/.git/FETCH_HEAD which is synchronized with this repository.

@jgalan
Copy link
Member

jgalan commented Mar 19, 2021

This command should do the job:

git ls-remote https://github.com/rest-for-physics/materials HEAD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants