Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add telescope extension to select env file #278

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

BingCoke
Copy link
Contributor

No description provided.

@NTBBloodbath
Copy link
Member

Hey, the truth is I never expected someone to do something like this and I love the idea, thank you very much!

I'm currently rewriting the entire plugin and I'd like this to be in the dev branch to include in the next version.

Also I saw this PR and decided to expose a function ("rest-nvim.functions").find_env_files() in the rewrite branch which I think could be very useful and would reduce the telescope extension code, also removing the optional dependency on fd :)

@BingCoke
Copy link
Contributor Author

Hey, the truth is I never expected someone to do something like this and I love the idea, thank you very much!嘿,事实是我从没想过有人会做这样的事情,我喜欢这个主意,非常感谢!

I'm currently rewriting the entire plugin and I'd like this to be in the dev branch to include in the next version.

Also I saw this PR and decided to expose a function ("rest-nvim.functions").find_env_files() in the rewrite branch which I think could be very useful and would reduce the telescope extension code, also removing the optional dependency on fd :)

Thanks you love this! By the way fd is telescope's dependency so no need to remove it.

@BingCoke
Copy link
Contributor Author

I think it could be better used as a extension as other plugin like project.nvim so that optional to load it.
I also want to add other feature like

  1. add lualine source, when we in http file we can check what env we select and add EditEnv command to edit current env file
  2. add http file snippets
  3. add attach function (you know there is not a http lsp) we can keybinding just in http file

Do you think these features could be added to this repository?

@NTBBloodbath
Copy link
Member

Woops, I just woke up and have some time to look at GitHub.

Of course, why not? Those ideas sound super useful, I will be happy to have them in the repository :p

@Otard95
Copy link

Otard95 commented Feb 2, 2024

This can be fairly easily accomplished in your own dotfiles as well. Here's my config for rest.nvim, hope it helps someone.

@BingCoke
Copy link
Contributor Author

BingCoke commented Feb 3, 2024

This can be fairly easily accomplished in your own dotfiles as well. Here's my config for rest.nvim, hope it helps someone.

yes of course,but i think it could be better be managed by this repo other than user's config.

@Otard95
Copy link

Otard95 commented Feb 3, 2024

yes of course,but i think it could be better be managed by this repo other than user's config.

I didn't mean to imply that it shouldn't, sorry if it came across that way. Only wanted to give an option to anyone else coming along in the mean time 😊

@NTBBloodbath NTBBloodbath merged commit 9bb8695 into rest-nvim:main Feb 12, 2024
1 of 2 checks passed
@NTBBloodbath
Copy link
Member

Sorry it took so long for me to merge this. I've been somewhat busy with other projects and the rest.nvim incoming version is also a priority, I'll make sure to cherry-pick this and the lualine features into the dev branch, thank you so much :)

NTBBloodbath pushed a commit that referenced this pull request Feb 12, 2024
NTBBloodbath pushed a commit that referenced this pull request Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants