Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented headers go through to the call #29

Closed
mr-majkel opened this issue Jun 30, 2021 · 1 comment · Fixed by #264
Closed

Commented headers go through to the call #29

mr-majkel opened this issue Jun 30, 2021 · 1 comment · Fixed by #264
Labels
bug Something isn't working

Comments

@mr-majkel
Copy link
Contributor

Hi, it seems that the comment line is ignored if does not have colon inside - this means that commenting out headers stopped working. I guess it is about order of parsing actions. The line should be ignored completely if it starts with #.

@NTBBloodbath
Copy link
Member

NTBBloodbath commented Jun 30, 2021

Hey, it can take a bit of time because Lua pattern matching is not the same as the regex in other languages but I'll try to fix it ASAP!

An example of this behavior is that we can't do (pattern1|pattern2) since Lua is not using POSIX regex.

That's the explanation of the reason of this, taken from the Lua programming language book.

Unlike several other scripting languages, Lua does not use POSIX regular expressions (regexp) for pattern matching. The main reason for this is size: A typical implementation of POSIX regexp takes more than 4,000 lines of code. This is bigger than all Lua standard libraries together. In comparison, the implementation of pattern matching in Lua has less than 500 lines. Of course, the pattern matching in Lua cannot do all that a full POSIX implementation does. Nevertheless, pattern matching in Lua is a powerful tool and includes some features that are difficult to match with standard POSIX implementations.

@NTBBloodbath NTBBloodbath added the bug Something isn't working label Jun 30, 2021
@NTBBloodbath NTBBloodbath added this to Needs triage in Bugs tracking via automation Jun 30, 2021
@NTBBloodbath NTBBloodbath moved this from Needs triage to High priority in Bugs tracking Jun 30, 2021
Bugs tracking automation moved this from High priority to Closed Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

2 participants