Allow Bifrost to modify Logs in case of missing Chains #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes restatedev#1323.
Let Bifrost obtain the number of partitions from the available partition table.
The PartitionProcessorManager is responsible for managing the lifecycle of PartitionProcessors. The set of partition processors can be modified by providing a PartitionProcessorPlan that contains actions how to change the running set of PartitionProcessors. At the moment only starting partition processors is supported.
This commit changes the APIs for obtaining the PartitionTable metadata to optional to underline the contract that a PartitionTable might not be loaded.
This commits moves the ground truth of th logs configuration to the metadata store from where it is also retrieved at start-up of Bifrost. This fixes restatedev#1336.
This commit allows Bifrost to update the Logs configuration in case a missing Chain for a given LogId is detected. In this case, the Bifrost client tries to update the Logs configuration with its configured default provider. This fixes restatedev#1341.
|
I'm not sure we should auto provision log-ids implicitly on appends. Provisioning logs should happen only during partition split or merge. I can think of many risks to this approach, too many to enumerate actually :D |
|
Fair point. What's currently not very intuitive is that the |
|
Should we close this one then? |
|
Jup. Closing as too dangerous. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows Bifrost to update the Logs configuration
in case a missing Chain for a given LogId is detected. In this
case, the Bifrost client tries to update the Logs configuration
with its configured default provider.
This fixes #1341.
This PR is based on #1338.
@AhmedSoliman let me know if this commit goes against the ideas you had for Bifrost.