Merge pull request #560 from joschi/resteasy-netty-hostname

Allow NettyJaxrsServer to bind to a specific hostname
resteasy · Sep 11, 2014 · 81b12aa · 81b12aa
2 parents 82029e6 + 8a1ab36
commit 81b12aa
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 3 deletions.
diff --git a/...esteasy-netty/src/main/java/org/jboss/resteasy/plugins/server/netty/NettyJaxrsServer.java b/...esteasy-netty/src/main/java/org/jboss/resteasy/plugins/server/netty/NettyJaxrsServer.java
@@ -31,6 +31,7 @@ public class NettyJaxrsServer implements EmbeddedJaxrsServer
 {
    protected ServerBootstrap bootstrap;
    protected Channel channel;
+   protected String hostname = null;
    protected int port = 8080;
    protected ResteasyDeployment deployment = new ResteasyDeployment();
    protected String root = "";
@@ -85,7 +86,15 @@ public void setKeepAlive(boolean isKeepAlive)
    {
        this.isKeepAlive = isKeepAlive;
    }
-
+
+   public String getHostname() {
+       return hostname;
+   }
+
+   public void setHostname(String hostname) {
+       this.hostname = hostname;
+   }
+
    public int getPort()
    {
       return port;
@@ -144,7 +153,14 @@ public void start()
       bootstrap.setPipelineFactory(factory);
 
       // Bind and start to accept incoming connections.
-      channel = bootstrap.bind(new InetSocketAddress(port));
+      final InetSocketAddress socketAddress;
+      if(null == hostname || hostname.isEmpty()) {
+          socketAddress = new InetSocketAddress(port);
+      } else {
+          socketAddress = new InetSocketAddress(hostname, port);
+      }
+
+      channel = bootstrap.bind(socketAddress);
       allChannels.add(channel);
    }
 

diff --git a/...steasy-netty4/src/main/java/org/jboss/resteasy/plugins/server/netty/NettyJaxrsServer.java b/...steasy-netty4/src/main/java/org/jboss/resteasy/plugins/server/netty/NettyJaxrsServer.java
@@ -19,6 +19,7 @@
 
 import javax.net.ssl.SSLContext;
 import javax.net.ssl.SSLEngine;
+import java.net.InetSocketAddress;
 
 /**
  * An HTTP server that sends back the content of the received HTTP request
@@ -33,6 +34,7 @@
 public class NettyJaxrsServer implements EmbeddedJaxrsServer
 {
    protected ServerBootstrap bootstrap = new ServerBootstrap();
+   protected String hostname = null;
    protected int port = 8080;
    protected ResteasyDeployment deployment = new ResteasyDeployment();
    protected String root = "";
@@ -82,6 +84,14 @@ public void setMaxRequestSize(int maxRequestSize)
        this.maxRequestSize  = maxRequestSize;
    }
 
+   public String getHostname() {
+       return hostname;
+   }
+
+   public void setHostname(String hostname) {
+       this.hostname = hostname;
+   }
+
    public int getPort()
    {
       return port;
@@ -174,7 +184,14 @@ public void initChannel(SocketChannel ch) throws Exception {
                    .childOption(ChannelOption.SO_KEEPALIVE, true);
        }
 
-        bootstrap.bind(port).syncUninterruptibly();
+       final InetSocketAddress socketAddress;
+       if(null == hostname || hostname.isEmpty()) {
+           socketAddress = new InetSocketAddress(port);
+       } else {
+           socketAddress = new InetSocketAddress(hostname, port);
+       }
+
+       bootstrap.bind(socketAddress).syncUninterruptibly();
    }
 
    @Override