RESTEASY-1684 - Arguments must not be null when sending a null JSON object with ResteasyWebTarget #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoldano
requested changes
Aug 8, 2017
| @@ -32,7 +32,7 @@ public MessageBodyParameterProcessor(MediaType mediaType, Class type, Type gener | |||
| @Override | |||
| public void process(ClientInvocationBuilder invocation, Object param) | |||
| { | |||
| invocation.getInvocation().setEntity(Entity.entity(new GenericEntity(param, genericType), mediaType, annotations)); | |||
| invocation.getInvocation().setEntity(Entity.entity(param == null? null : new GenericEntity<Object>(param, genericType), mediaType, annotations)) | |||
There was a problem hiding this comment.
darn 🤦 !
Let me fix that right away...
…bject with ResteasyWebTarget
|
OK this time it ssems to NOT be related to my changes. @asoldano of course if you feel it might be, let me know and I'll dig deeper. |
asoldano
approved these changes
Nov 7, 2017
ronsigal
added a commit
that referenced
this pull request
Dec 14, 2017
Adding test for pull request #1240.
|
I'm going to merge this. #1365 has a test for for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.jboss.org/browse/JBEAP-11860
Upstream Issue: https://issues.jboss.org/browse/RESTEASY-1684
Upstream PR: #1206
Backporting fix for RESTEASY-1684 to branch 3.0.19.SPX (thus for EAP 7.0.x)