[RESTEASY-1815 + RESTEASY-1819] Sse tests #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanovotn
force-pushed
the
RESTEASY-1815-m
branch
4 times, most recently
from
f4e5199
to
370b941
Compare
asoldano
requested changes
Mar 5, 2018
There was a problem hiding this comment.
Hi @kanovotn , generally speaking, I'm fine with the proposed tests here. What I'm a bit concerned about is that one of the Travis CI runs failed on one of the added test. Can you please check and tell if that makes any sense to you? It might be a timining issue or such.
As a minor thing, there're a couple of System.out.println(..) that can probably be removed or replaced with loggers.
kanovotn
force-pushed
the
RESTEASY-1815-m
branch
2 times, most recently
from
1ceebea
to
9cdf623
Compare
|
@asoldano, The failing one test was trying to simulate call of onError callback on SseBroadcaster. After checking this, I think need to use byteman to simulate this in a always repeatable way. I removed the test for now, because there is no support in resteasy testsuite for byteman, I will send this in another PR. |
[RESTEASY-1815] Eventsourcetest [RESTEASY-1815] SseBroadcasterTest
kanovotn
force-pushed
the
RESTEASY-1815-m
branch
from
9cdf623
to
9ca5152
Compare
kanovotn
changed the title
kanovotn
force-pushed
the
RESTEASY-1815-m
branch
from
9ca5152
to
ed70a03
Compare
kanovotn
force-pushed
the
RESTEASY-1815-m
branch
from
ed70a03
to
209de41
Compare
asoldano
approved these changes
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.