OnComplete callback registered via SseEventSource.register() must be called only once #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass. Signed-off-by: NicoNes <nicolas.nesmon@gmail.com>
…dlers when there are further events to be received. Signed-off-by: NicoNes <nicolas.nesmon@gmail.com>
Signed-off-by: NicoNes <nicolas.nesmon@gmail.com>
Merged
asoldano
approved these changes
Jul 10, 2018
|
Thanks @NicoNes ! |
asoldano
pushed a commit
to asoldano/Resteasy
that referenced
this pull request
Jul 10, 2018
…ister() must be called only once (resteasy#1599) * Remove @category(ExpectedFailing.class) on test that is supposed to pass. Signed-off-by: NicoNes <nicolas.nesmon@gmail.com> * Add internalClose() to close SseEventSource and invoke completion handlers when there are further events to be received. Signed-off-by: NicoNes <nicolas.nesmon@gmail.com> * Code cleaning to improve lisibility Signed-off-by: NicoNes <nicolas.nesmon@gmail.com>
asoldano
pushed a commit
that referenced
this pull request
Jul 10, 2018
…ister() must be called only once (#1599) * Remove @category(ExpectedFailing.class) on test that is supposed to pass. Signed-off-by: NicoNes <nicolas.nesmon@gmail.com> * Add internalClose() to close SseEventSource and invoke completion handlers when there are further events to be received. Signed-off-by: NicoNes <nicolas.nesmon@gmail.com> * Code cleaning to improve lisibility Signed-off-by: NicoNes <nicolas.nesmon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to remove multiple invocation of SseEventSource completion handlers and enable test about it.
@ronsigal You might be interested by this PR since it seem's that the regression has been introduced by #1478
@rnetuka and @kanovotn You also might be interested by this PR as an enrichment to what have been done in https://github.com/resteasy/Resteasy/pull/1435/files