Fix invokeAsync with @PathParam annotations #1848
Conversation
|
@fabienrousseau thanks for your contribution. Can you please provide a bit more information on the issue, how you're reproducing it, etc? A new jira issue (https://issues.jboss.org/browse/RESTEASY) would actually be great. |
|
Sorry, I already opened an issue but forgot to link it back to the PR: https://issues.jboss.org/browse/RESTEASY-2139 |
| ClientContext context = new ClientContext(request, response, entityExtractorFactory); | ||
| return extractor.extractEntity(context); | ||
| } | ||
|
|
||
| protected ClientInvocation createRequest(Object[] args) | ||
| protected ClientInvocationBuilder createRequest(Object[] args) |
There was a problem hiding this comment.
Good point, @marekkopecky. It's probably not a problem, but it's good to be safe. @fabienrousseau, can you just move the line
builder.setInvocation(request);
to the end of createRequest(), where it would become
builder.setInvocation(clientInvocation);
?
|
Master PR would be useful as well ... I check 3.6 branch, proxy + MP REST client, Single + CompletionStage, RESTEasy works as expected in my checks, IllegalArgumentException is no more thrown |
|
Thanks @marekkopecky ; yes, if possible it would be really better not changing that method signature. The class is in a package named "internal", still we should try avoiding changing it this way. |
|
Replaced by #1900 , thanks anyway for the contribution! |
No description provided.