[RESTEASY-2244] @Produces not picked up well #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @spyrkob. Would you be interested in writing a test in which the return media type comes from the resource class? |
|
@ronsigal sure, can do that, but without some hackery it won't be possible to reproduce the issue as the correct Producer would be returned by the method.getProduces() already. |
|
@spyrkob, yeah, you're right. Good point. I suspect that the best practice would be to have a test in place just to prevent any future regressions. With a note explaining that there is currently no way for the test to fail. If you don't mind. ;-) |
asoldano
approved these changes
Aug 5, 2019
spyrkob
force-pushed
the
RESTEASY-2244/master
branch
from
9a4c462
to
e8f14de
Compare
|
@ronsigal added the test, let me know if it looks OK |
spyrkob
force-pushed
the
RESTEASY-2244/master
branch
from
e8f14de
to
ed6a551
Compare
|
@asoldano sorry my IDE must have messed up something... should be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.jboss.org/browse/RESTEASY-2244