resteasy-reactor: Fix a null case that causes hang
#2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replaced code in `MonoProvider` was blindly copied from rxjava2. We use this code in our application and the code in `testToCompletionStageNullCase` represents a scenario our app deals with. With the `MonoAdapter`, that code hangs. Leveraging the existing `Mono#toFuture`, which I should have done in the first place, addresses that hang.
anilgursel
approved these changes
Aug 30, 2019
asoldano
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replaced code in
MonoProviderwas blindly copied from rxjava2. Weuse this code in our application and the code in
testToCompletionStageNullCaserepresents a scenario our app deals with. With the
MonoAdapter, thatcode hangs. Leveraging the existing
Mono#toFuture, which I shouldhave done in the first place, addresses that hang.