Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MP Rest Client allow async interceptor invocation #2216

Merged
merged 1 commit into from Nov 13, 2019
Merged

MP Rest Client allow async interceptor invocation #2216

merged 1 commit into from Nov 13, 2019

Conversation

michalszynkiewicz
Copy link
Contributor

@michalszynkiewicz michalszynkiewicz mentioned this pull request Nov 13, 2019
Closed
@gsmet
Copy link
Contributor

gsmet commented Nov 13, 2019

@asoldano could you have a look at that one? It would be nice if we could include it in the Final of Quarkus if it's legit.

Thanks!

asoldano
asoldano approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@asoldano asoldano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm including this as it looks fine. However, I'm wondering how hard it would be to add a testcase for this.

@asoldano
Copy link
Member

@asoldano could you have a look at that one? It would be nice if we could include it in the Final of Quarkus if it's legit.

Thanks!

Yep, planning to do that.

@asoldano asoldano merged commit 3cfcffa into resteasy:master Nov 13, 2019
@asoldano asoldano added the main label Nov 13, 2019
@michalszynkiewicz
Copy link
Contributor Author

@asoldano it shouldn't be difficult to add a test for it, I will try to add it when I have a while. Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asoldano asoldano asoldano approved these changes

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
main
Projects
None yet
Milestone
No milestone
4 participants
@michalszynkiewicz @gsmet @asoldano @manovotn