Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RESTEASY-2886] RESTEasy Java 16 Fixes #2796

Merged
merged 10 commits into from May 27, 2021
Merged

Conversation

jamezp
Copy link
Contributor

@jamezp jamezp commented May 21, 2021

Copy link
Collaborator

@liweinan liweinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@jamezp
Copy link
Contributor Author

jamezp commented May 24, 2021

I'm not too sure what is going on with the Spring tests. I'm not able to reproduce them locally, but I'll have a closer look soon.

@ronsigal ronsigal added the main label May 24, 2021
@ronsigal ronsigal changed the title RESTEasy Java 16 Fixes [RESTEASY-2886] RESTEasy Java 16 Fixes May 24, 2021
@ronsigal
Copy link
Collaborator

Ah, ok. I didn't see that last comment when I sent my email about this pull request and 4.6.1.Final.

@jamezp
Copy link
Contributor Author

jamezp commented May 24, 2021

@ronsigal No problem. It looks like I've fixed them :)

@@ -16,7 +16,7 @@
<name>RESTEasy Main testsuite: Spring Web integration tests</name>

<properties>
<version.org.springframework>5.0.14.RELEASE</version.org.springframework>
<version.org.springframework>5.3.7</version.org.springframework>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these versions properties be moved to resteasy-dependencies-bom?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually has to live in both places because of https://github.com/resteasy/Resteasy/blob/da6aaedc5e64f8403536e105cc0e451a1fc60535/testsuite/integration-tests-spring-web/deployment/pom.xml#L164-L203. Properties are not inherited from imported POM's.

@ronsigal ronsigal merged commit 1738509 into resteasy:main May 27, 2021
@jamezp jamezp deleted the RESTEASY-2886 branch June 8, 2021 22:55
liweinan pushed a commit to liweinan/Resteasy that referenced this pull request Dec 29, 2022
* [RESTEASY-2904] Upgrade the test WildFly version to 23.0.2.Final.

https://issues.redhat.com/browse/RESTEASY-2904

* [RESTEASY-2895] Upgrade Google Guice to 5.0.1

https://issues.redhat.com/browse/RESTEASY-2895

* [RESTEASY-2896] Upgrade Undertow to 2.2.7.Final

https://issues.redhat.com/browse/RESTEASY-2896

* [RESTEASY-2897] Upgrade Weld to 3.1.7.SP1 and the API to 3.1.SP4

https://issues.redhat.com/browse/RESTEASY-2897

* [RESTEASY-2898] Upgrade WildFly CLI to 15.0.1.Final.

https://issues.redhat.com/browse/RESTEASY-2898

* [RESTEASY-2899] Upgrade mockito to 3.10.0

https://issues.redhat.com/browse/RESTEASY-2899

* [RESTEASY-2900] Upgrade Spring to 5.3.7.

https://issues.redhat.com/browse/RESTEASY-2900

* [RESTEASY-2902] Drop legacy WildFly security configuration options and only configure Elytron.

https://issues.redhat.com/browse/RESTEASY-2902

* [RESTEASY-2903] Ignore remote EJB tests until WFLY-14668 is resolved and WildFly 24 is released.

https://issues.redhat.com/browse/RESTEASY-2903

* [RESTEASY-2886] Add the JDK module options required for Java 16+. Upgrade the version of Jetty used for the MicroProfile TCK and modify the timeout for Java 16+.

https://issues.redhat.com/browse/RESTEASY-2886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants