Fixing the ResteasyViolationException#toString concurrency #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rhuan Rocha <rhuan080@gmail.com>
|
This will need a JIRA too please, https://issues.redhat.com/browse/RESTEASY. |
Signed-off-by: Rhuan Rocha <rhuan080@gmail.com>
|
Hi, Any update on this? |
|
Hi @rhuan080. Sorry for the delay. Hopefully I'll get a chance to address these this week. |
|
Thank you @jamezp! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rhuan Rocha rhuan080@gmail.com
This issue was identified in a scenario that the exception' object is delegated to a task that works in other threads. As it uses the iterator on ResteasyViolationException#toString and it calls the convertViolations method (that modifies the violationLists) it can generate an issue if called concurrently. I have seen it on 3.9.3.SP1-redhat-00001. It is why I'm sending a PR to this branch. However, the main branch has the same problem. I'll send a PR to the main soon.