master branch

[ronsigal]

RESTEASY-1008: Validation now works in the presence of CDI.

[fabian]

Well actually validation requires CDI now.

See: https://github.com/resteasy/Resteasy/pull/479/files#diff-67

[patriot1burke]

thought it was the other way around?

[gbervik]

It seems to be because GeneralValidatorImpl references org.jboss.resteasy.cdi.ResteasyCdiExtension

https://github.com/resteasy/Resteasy/pull/479/files#diff-c8eb53d63c13781d8ad411833859fd78R21

[ronsigal]

Here's the deal. Normally, validation is done by Resteasy core. But in the presence of CDI, I had to move validation into resteasy-cdi. To distinguish the two cases, I extended GeneralValidator with interface GeneralValidatorCDI, with two new methods, isValidatableFromCDI() and isMethodValidatableFromCDI(). When Resteasy core calls isValidatable() or isMethodValidatable(), it will get the answer false if CDI is active. When the other two methods are called from resteasy-cdi, they will return whatever the answer should be. So the two versions of GeneralValidatorImpl need to know if CDI is active, which is why it depends on resteasy-cdi.

[ronsigal]

It's also true that resteasy-cdi depends on validation, since it performs validation. But the dependency is indirect, since it gets a validator by calling a ContextResolver.

[ronsigal]

This conversation seems to start in the middle, with "Well actually validation requires CDI now." What's up? Is there a problem?

[gbervik]

The problem for me was https://github.com/resteasy/Resteasy/pull/479/files#diff-c8eb53d63c13781d8ad411833859fd78R72

I didn't have ResteasyCdiExtension on my classpath and it threw a NoClassDefFoundError. The catch block is for an Exception, not an Error so it caused an issue.

[ronsigal]

Ah, Ok. I'll change that to catch a Throwable. Thanks.

[gbervik]

Isn't there a cleaner way the check can be done? Catching a NoClassDefFoundError seems like a bit of a hack. Even the javadoc for java.lang.Error says "An Error is a subclass of Throwable that indicates serious problems that a reasonable application should not try to catch"

I'm not familiar with the Resteasy internals, but couldn't ResteasyCdiExtension.observeBeforeBeanDiscovery() update something in core that GeneralValidatorImpl could check? Then validation wouldn't be dependent on CDI