[Netty4] Correct handling for absolute URIs in HTTP request lines

[avram]

Correctly handle requests with an absolute URI in the request line, like:

GET http://www.example.com/testContent HTTP/1.1
Host: www.example.com

This is required per the spec: http://tools.ietf.org/html/rfc2616#section-5, specifically:

To allow for transition to absoluteURIs in all requests in future versions of HTTP, all HTTP/1.1 servers MUST accept the absoluteURI form in requests, even though HTTP/1.1 clients will only generate them in requests to proxies.

And:

If Request-URI is an absoluteURI, the host is part of the Request-URI. Any Host header field value in the request MUST be ignored.

Issue: https://issues.jboss.org/browse/RESTEASY-1193

[avram]

This tests uses sockets directly since the Resteasy client builders don't support making requests with absolute URIs in the request line.

[avram]

@patriot1burke Can you take a look at this change? It looked to me like a divergence from the HTTP spec, and reproducible easily with RxNetty.

[ronsigal]

Hi Avram,

I have a suggestion for a test:

  @GET
  @Path("/test/absolute")
  @Produces("text/plain")
  public String absolute(@Context UriInfo info)
  {
      return "uri: " + info.getRequestUri().toString();
  }

and

@Test
public void testAbsoluteURI() throws Exception {
   String uri = generateURL("/test/absolute");

   Socket client = new Socket(getHost(), getPort());
   PrintWriter out = new PrintWriter(client.getOutputStream(), true);
   BufferedReader in = new BufferedReader(new InputStreamReader(client.getInputStream()));
   out.printf(Locale.US, "GET %s HTTP/1.1\nHost: %s:%d\n\n", uri, "127.0.0.1", getPort());
   String statusLine = in.readLine();
   String response = in.readLine();
   while (!response.startsWith("uri")) 
   {
       response = in.readLine();
   }
   client.close();
   Assert.assertEquals("HTTP/1.1 200 OK", statusLine);
   Assert.assertEquals(uri, response.subSequence(5, response.length()));

}

This test proves that NettyUtil is using the given absolute URI in the GET line rather than constructing a URI.

[ronsigal]

Other than that, the patch looks good. Avram, could you create a JIRA issue here: https://jira.jboss.org/browse/RESTEASY ?

[avram]

Fixed and rebased vs master. Issue incoming.

[avram]

Issue: https://issues.jboss.org/browse/RESTEASY-1193

[ronsigal]

Thanks, Avram. Looks good to merge.