-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add listener constructor #956
Conversation
Whoops, I just checked the pom file. The |
@Sineaggi we'll eventually upgrade to a more recent spring version in the future, not now though. What is the minimum requirement for your change here, Spring 4.3.0? |
@asoldano I've just tested, Edit: Just tested version numbers again, I was able to drop requirements as low as Spring 3.1.0. |
Not sure what the failing test is about.
|
776a905
to
fb0da4c
Compare
Fixed, seems like it was a fluke. |
OK, thanks. Currently reasoning on the implications of spring upgrade, to decide when to merge this PR. |
OK, I've squashed your commits in a single one and merged upstream after having moved to Spring 3.1.0.RELEASE. Thanks! |
Thank you! |
I hope that this time the pull request will not be reverted anymore, ref. my previous accepted and then reverted pull request #623 (2 Feb 2015) |
This allows for code such as
to be used inside of a servlet 3.0 container such as the Jetty server, without requiring
web.xml
andapplicationContext.xml
files.