[Resteasy-2700] reactor netty server adapter #2693

crankydillo · 2021-03-16T22:12:21Z

We have an investment in RestEasy and Reactor-Netty. As such, we'd like to leverage reactor-netty as the server behind RestEasy's JAX-RS-server implementation. Once this is merged, we will create a resteasy-springboot contribution that leverages this work.

Our hope is that you will not squash-merge if that's possible as this work was done by all the people you see in the commit history.

asoldano

Thanks @crankydillo , this looks very interesting.

In order for merging, we need all contributors to agree with the license agreement; most of you already did that in the past, I believe @abhijith-prabhakar is the only one missing.
@abhijith-prabhakar , can you confirm you agree your contributions are made under the terms of the ASL 2.0 License: http://www.apache.org/licenses/LICENSE-2.0 ?

@crankydillo , would you be interested in adding something meaningful in the documentation (around here https://docs.jboss.org/resteasy/docs/4.6.0.Final/userguide/html/RESTEasy_Embedded_Container.html ) or to write a blog post describing the feature?

Thanks

asoldano · 2021-03-18T10:45:14Z

server-adapters/resteasy-reactor-netty/src/test/java/org/jboss/resteasy/test/SniTest.java

+/**
+ * Tests SNI capabilities for Netty based JaxRS server.
+ *
+ * @author Sebastian Łaskawiec
+ * @see https://issues.jboss.org/browse/RESTEASY-1431
+ *
+ * TODO what is SNI??
+public class SniTest
+{


As for SNI, see the RESTEASY-1431 jira above and https://tools.ietf.org/html/rfc6066#page-6
If this is not implemented, I suggest creating a followup jira after this will be merged. Also better removing this test class completely instead of having it fully commented.

This PR may not suggest it, but our team almost never leaves commented-out code. Apologies for that!

I will see the JIRA and the RFC. If we still feel it should be unimplemented, I will remove this test. Ditto for all other commented out code.

@asoldano AFAIK, we don't personally need SNI mapping at this time. I removed the test. If you feel this is critical functionality, please let us know.

asoldano · 2021-03-18T11:10:24Z

@crankydillo as for not squash-merging, that's fine. Usually the reason for doing that is making it easy to isolate changes for a given feature/contribution. Would you mind amending the few commits whose commit messages do not start with [RESTEASY-2700] or RESTEASY-2700 already so that they actually start like that? That would help, thanks!

asoldano · 2021-03-18T11:17:50Z

@crankydillo I've re-started the CI tests. The failures on Windows are frequently environmental (we're investigating them), though the org.jboss.resteasy.test.HeaderTooLongTest failure in one of the linux run is possibly relevant. Should it fail again, it will have to be addressed.

jamezp

Thank you for your contribution! Overall I think this looks fine. It looks very similar to the Netty adaptor which is nice.

The biggest change we need to make is not using slf4j and using jboss-logging instead.

jamezp · 2021-03-18T15:46:04Z

resteasy-dependencies-bom/pom.xml

@@ -106,7 +106,7 @@
        <version.org.jboss.marshalling.jboss-marshalling>2.0.6.Final</version.org.jboss.marshalling.jboss-marshalling>
        <version.rest-assured>3.3.0</version.rest-assured>
        <version.org.springframework>5.2.0.RELEASE</version.org.springframework>
-        <version.io.projectreactor>Dysprosium-SR12</version.io.projectreactor>
+        <version.io.projectreactor>2020.0.4</version.io.projectreactor>


Not critical, but 2020.0.5 was release a few days ago. We may as well upgrade it.

server-adapters/resteasy-reactor-netty/pom.xml

jamezp · 2021-03-18T15:47:35Z

server-adapters/resteasy-reactor-netty/pom.xml

+        <dependency>
+            <groupId>org.jboss.logging</groupId>
+            <artifactId>jboss-logging-processor</artifactId>
+        </dependency>


This should be marked as <scope>provided</scope>. Not required, but <optional>true</optional> could also be added. This is a compile time only requirement.

jamezp · 2021-03-18T15:48:10Z

server-adapters/resteasy-reactor-netty/pom.xml

+        <dependency>
+            <groupId>ch.qos.logback</groupId>
+            <artifactId>logback-classic</artifactId>
+            <version>1.2.3</version>
+        </dependency>


Is this a required dependency? Ideally we should not be requiring a log manager.

I'm assuming this will be rectified when I change to jboss-logging..

Okay excellent thanks!

jamezp · 2021-03-18T15:49:12Z

server-adapters/resteasy-reactor-netty/pom.xml

+        <dependency>
+            <groupId>io.projectreactor.tools</groupId>
+            <artifactId>blockhound</artifactId>
+            <version>1.0.3.RELEASE</version>


Is this dependency not in the BOM? If it is we should likely remove the version here.

I will check this.

I will just remove it since it doesn't look like we used it.

...y/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/ReactorNettyJaxrsServer.java

jamezp · 2021-03-18T17:13:24Z

...actor-netty/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/i18n/Messages.java

+    @Message(id = BASE + 10, value = "Chunk size must be at least 1")
+    String chunkSizeMustBeAtLeastOne();
+
+    @Message(id = BASE + 12, value = "Exception caught by handler")
+    String exceptionCaught();
+
+    @Message(id = BASE + 15, value = "Failed to parse request.")
+    String failedToParseRequest();
+
+    @Message(id = BASE + 20, value = "response is committed")
+    String responseIsCommitted();
+
+    @Message(id = BASE + 25, value = "Unexpected")
+    String unexpected();


These do not appear to be used and should be deleted.

...actor-netty/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/i18n/Messages.java

jamezp · 2021-03-18T17:27:29Z

server-adapters/resteasy-reactor-netty/src/test/java/org/jboss/resteasy/test/NettyTest.java

+   // we can consider adding the feature.
+   // TODO we do not set 'ChannelHandlerContext' (see resource method)
+   // Are we supposed to be doing something there?
+   //@Test


Minor nit, could we keep the @Test here and add @Ignore please? Or we could just delete it.

Not minor to us! I almost certainly will remove this.

crankydillo · 2021-03-22T21:42:32Z

Thanks @crankydillo , this looks very interesting.

Thanks!

@crankydillo , would you be interested in adding something meaningful in the documentation (around here https://docs.jboss.org/resteasy/docs/4.6.0.Final/userguide/html/RESTEasy_Embedded_Container.html ) or to write a blog post describing the feature?

I will add to this PR a commit that targets that HTML page.

crankydillo

Thanks for the quick feedback! I should be able to incorporate the requested changes within a few days.

crankydillo · 2021-03-22T21:48:22Z

...r-netty/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/ChunkOutputStream.java

+
+   @Override
+   public void write(int b) {
+      byteSink.emitNext(Tuples.of(new byte[] {(byte)b}, new CompletableFuture<>()), EMIT_FAILURE_HANDLER);


Good eye. I will look into this. It's definitely fair to say we were focused on asyncWrite...

crankydillo · 2021-03-22T21:49:17Z

...r-netty/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/ChunkOutputStream.java

+        if (!started) {
+            byteSink = byteSinkSupplier.get();
+            parentResponse.committed();
+            started = true;
+        }


We only needed double-checking if it can be called from different threads 'simultaneously', right? Is that a possibility?

crankydillo · 2021-03-22T21:49:43Z

...asy-reactor-netty/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/Logging.java

+package org.jboss.resteasy.plugins.server.reactor.netty;
+
+public interface Logging {
+}


Yes, this was not supposed to be committed.

crankydillo · 2021-03-22T21:51:35Z

...y-reactor-netty/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/NettyUtil.java

+import java.util.List;
+import java.util.Map;
+
+// TODO copied from netty4.  Do we make common?


I will clean this up. However, if I do end up with anything beyond the most trivial copying, should I just mention them by name (@author)?

crankydillo · 2021-03-22T21:53:59Z

...tty/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/ReactorNettyContainer.java

+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class ReactorNettyContainer {


Honestly, it was 6 months ago when I wrote this. I believe it is only used from test. I did get the pattern from other adapters. I will need to see if our spring-boot starter work leverages it.

crankydillo · 2021-03-22T22:00:26Z

...y/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/ReactorNettyJaxrsServer.java

+      root = rootResourcePath;
+      if (root != null && root.equals("/")) {
+         root = "";
+      } else if (!root.startsWith("/")) {


What would you like it to throw? I generally prefer to bubble NPE. However, I would likely have used Objects#requireNonNull on line 87. Should it set it to null or the empty string when the supplied argument is null? I will check the javadoc to see if it gives guidance.

...y/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/ReactorNettyJaxrsServer.java

...actor-netty/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/i18n/Messages.java

crankydillo · 2021-03-22T22:04:05Z

server-adapters/resteasy-reactor-netty/src/test/java/org/jboss/resteasy/test/NettyTest.java

+   // we can consider adding the feature.
+   // TODO we do not set 'ChannelHandlerContext' (see resource method)
+   // Are we supposed to be doing something there?
+   //@Test


Not minor to us! I almost certainly will remove this.

crankydillo · 2021-03-22T22:07:53Z

@crankydillo I've re-started the CI tests. The failures on Windows are frequently environmental (we're investigating them), though the org.jboss.resteasy.test.HeaderTooLongTest failure in one of the linux run is possibly relevant. Should it fail again, it will have to be addressed.

Hi @asoldano . Did you re-run it? I will see if I can replicate on my home box, which is Linux Mint-based.

…andling improvements (#3) * Build UriInfo from full URI * Tests to verify UriInfo * Server error handling update * Update server-adapters/resteasy-reactor-netty/src/test/java/org/jboss/resteasy/plugins/server/reactor/netty/ClientUncheckedErrorTest.java Co-authored-by: Sharath Srinivasa <sharathsrinivasa@users.noreply.github.com> Co-authored-by: Samuel Cox <crankydillo@gmail.com> Co-authored-by: Sharath Srinivasa <sharathsrinivasa@users.noreply.github.com>

Co-authored-by: Abhijith Prabhakar <abprabhakar@paypal.com>

crankydillo · 2021-03-23T13:01:31Z

@asoldano @jamezp I believe I addressed everything I didn't have questions about.

abhijith-prabhakar · 2021-03-23T13:33:12Z

Thanks @crankydillo , this looks very interesting.

In order for merging, we need all contributors to agree with the license agreement; most of you already did that in the past, I believe @abhijith-prabhakar is the only one missing.
@abhijith-prabhakar , can you confirm you agree your contributions are made under the terms of the ASL 2.0 License: http://www.apache.org/licenses/LICENSE-2.0 ?

@crankydillo , would you be interested in adding something meaningful in the documentation (around here https://docs.jboss.org/resteasy/docs/4.6.0.Final/userguide/html/RESTEasy_Embedded_Container.html ) or to write a blog post describing the feature?

Thanks

Yes, I agree

Some notables: use jboss-logging, add HEAD test, deal with several potential NPEs, use JDK `Collections`, and remove SniTest. SNI support can be added later (when someone needs it:)

crankydillo · 2021-03-24T12:00:34Z

The build complained about a checkstyle error. I force-pushed a fix for that. I'll push the doc changes to the embedded-server HTML page in just a bit.

crankydillo · 2021-03-24T13:37:59Z

The build complained about a checkstyle error. I force-pushed a fix for that. I'll push the doc changes to the embedded-server HTML page in just a bit.

@asoldano I pushed the doc addition in this commit.

crankydillo · 2021-03-24T14:07:08Z

I see the HeaderTooLongTest failure in ubuntu-latest, 11, 210.01.Final. I will investigate it. If you know of any other failure, please let me know. For now, I will assume this is the one that was mentioned when I first created the PR.

Error:

rror:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.049 s <<< FAILURE! - in org.jboss.resteasy.test.HeaderTooLongTest
Error:  testLongHeader(org.jboss.resteasy.test.HeaderTooLongTest)  Time elapsed: 0.041 s  <<< ERROR!
javax.ws.rs.ProcessingException: RESTEASY004655: Unable to invoke request: java.net.SocketException: Broken pipe (Write failed)
	at org.jboss.resteasy.client.jaxrs.engines.ManualClosingApacheHttpClient43Engine.invoke(ManualClosingApacheHttpClient43Engine.java:297)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.invoke(ClientInvocation.java:492)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.invoke(ClientInvocation.java:67)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocationBuilder.get(ClientInvocationBuilder.java:190)
	at org.jboss.resteasy.test.HeaderTooLongTest.testLongHeader(HeaderTooLongTest.java:68)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:383)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:344)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:125)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:417)
Caused by: java.net.SocketException: Broken pipe (Write failed)
	at java.base/java.net.SocketOutputStream.socketWrite0(Native Method)
	at java.base/java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:110)
	at java.base/java.net.SocketOutputStream.write(SocketOutputStream.java:150)
	at org.apache.http.impl.io.SessionOutputBufferImpl.streamWrite(SessionOutputBufferImpl.java:124)
	at org.apache.http.impl.io.SessionOutputBufferImpl.flushBuffer(SessionOutputBufferImpl.java:136)
	at org.apache.http.impl.io.SessionOutputBufferImpl.flush(SessionOutputBufferImpl.java:144)
	at org.apache.http.impl.BHttpConnectionBase.doFlush(BHttpConnectionBase.java:174)
	at org.apache.http.impl.DefaultBHttpClientConnection.flush(DefaultBHttpClientConnection.java:183)
	at org.apache.http.impl.conn.CPoolProxy.flush(CPoolProxy.java:167)
	at org.apache.http.protocol.HttpRequestExecutor.doSendRequest(HttpRequestExecutor.java:241)
	at org.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:123)
	at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:272)
	at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:186)
	at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
	at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
	at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
	at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:56)
	at org.jboss.resteasy.client.jaxrs.engines.ManualClosingApacheHttpClient43Engine.invoke(ManualClosingApacheHttpClient43Engine.java:278)
	... 34 more

crankydillo · 2021-03-29T12:10:41Z

@asoldano @jamezp Do you have any tips on debugging the Ubuntu latest (20.04.2 LTS) - JDK 11, Wildfly 21.0.1.Final test failure? Docker, VM, etc? RE Wildfly, is that a player for a server adapter?

Any tips are appreciated.

asoldano · 2021-04-01T07:21:38Z

@crankydillo , I'm not sure how much this will help, but here area few thoughts I have on the topic:

as the failure being investigate here (HeaderTooLongTest) is in the server-adapters/resteasy-reactor-netty component, WildFly plays no role; this means that the 2 ubuntu-latest 1.8 are equivalent (and the same applies to the ubuntu-latest 11, etc) for it
you might want to modify the github CI configuration (see .github/workflows/maven.yml) to only execute the server-adapters/resteasy-reactory-netty testsuite (hopefully it will keep on failing, but it would be faster to re-run the tests). I'm fine with that being done here (and later reverted) or in another PR just for "debug" purposes, as you prefer
I suspect a timing issue or some type of race could be hiding here; I can't reproduce the failure locally, I believe the github CI jobs are executed in an environment with very limited resources

crankydillo · 2021-04-02T22:34:48Z

@asoldano Thanks for the tips. I can reproduce the failure pretty easily just by increasing the size of the header value. I get the same error, which I hope means it's the same problem:) I'm thinking the issue may be with reactor-netty. I'm working on a failing test (and hopefully fix) for their codebase. We'll see.

I must say though that this 413 behavior isn't 'super critical' for us. From the customer perspective, it ultimately is a request failure. However, it would be nice to always get a nice response. As @anilgursel points out in the test comment, one thing we probably want to do here is make the max header size configurable. That may prove more important than a nice message for super large header values..

[reactor-netty issue](reactor/reactor-netty#1584) which will soon be documented on their codebase. Basically, they fail to read the entire request before closing the connection. This is something we are willing to live with for now.. The test was adjust to show that if the header value is too long (but not too too long:), the server will respond with a 413. While doing this, I noticed that reactor-netty has added its own 'idle timeout' functionality so we'll leverage that instead of registering custom netty handlers. [RESTEASY-2700](https://engineering.paypalcorp.com/jira/browse/RESTEASY-2700)

crankydillo · 2021-04-06T02:39:38Z

@asoldano Looks like all are passing except for windows. You mentioned you often have issues there. I just glanced, but it looks the errors are related to vertx. Hopefully, there is nothing in this PR affecting that.

asoldano · 2021-04-06T12:10:38Z

@crankydillo thanks a lot! Yep, the resteasy-vertx failures in windows are unrelated, actually those are being addressed elsewhere soon.
Perhaps there's still something to address in @jamezp review comments?
I'll give a bit more time to @ronsigal and @jamezp for reviewing again before merging in any case.
Thanks

crankydillo · 2021-04-06T12:17:59Z

I thought I covered all of @jamezp comments, but if I missed one, I trust he'll let me know:)

crankydillo · 2021-04-09T20:22:13Z

@asoldano Apologies for pestering. Any ideas on a time-frame for this? :)

jamezp

I've only really reviewed my previous comments which I still have a couple questions on. I can give it a full review again though as well if needed.

jamezp · 2021-04-12T20:17:34Z

...r-netty/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/ChunkOutputStream.java

+        if (!started) {
+            byteSink = byteSinkSupplier.get();
+            parentResponse.committed();
+            started = true;
+        }


Where have we ended up on this? Do we know if the output stream is not thread safe?

jamezp · 2021-04-12T20:49:55Z

...y/src/main/java/org/jboss/resteasy/plugins/server/reactor/netty/ReactorNettyJaxrsServer.java

+      root = rootResourcePath;
+      if (root != null && root.equals("/")) {
+         root = "";
+      } else if (!root.startsWith("/")) {


@ronsigal Do you know if a null root resource is valid?

package-private. [RESTEASY-2700](https://engineering.paypalcorp.com/jira/browse/RESTEASY-2700)

crankydillo · 2021-04-16T02:26:37Z

I think I addressed everything. If I missed something, please let me know.

crankydillo · 2021-04-19T14:07:38Z

@asoldano @jamezp I'm back to pester again:) Did I miss anything?

asoldano · 2021-04-19T16:26:56Z

@crankydillo thanks for the update. I think we are fine for merging this now. As the release might not come very soon, we might still have a bit more of time to fix problems if there's need to. Thanks!

[RESTEASY-2700] Initial check-in of reactor-netty based server adapter.

04da97e

asoldano reviewed Mar 18, 2021

View reviewed changes

asoldano added the main label Mar 18, 2021

asoldano requested review from jamezp and ronsigal March 18, 2021 11:12

jamezp requested changes Mar 18, 2021

View reviewed changes

crankydillo commented Mar 22, 2021

View reviewed changes

sharathsrinivasa and others added 6 commits March 23, 2021 05:34

[RESTEASY-2700] Add SSL support for reactor netty server (#2)

177e598

[RESTEASY-2700] @anilgursel contributions. (#5)

ec3d037

[RESTEASY-2700] - Removed deprecated processor API code (#6)

15d6ff0

[RESTEASY-2700] Adding clean up tasks to reactor netty JAXRS server

299be50

Co-authored-by: Abhijith Prabhakar <abprabhakar@paypal.com>

[RESTEASY-2700] 'Undo' some unintentional overwrites.

17a6e08

crankydillo force-pushed the RESTEASY-2700_reactor-netty-server-adapter branch 2 times, most recently from 2efcec7 to 6f0855a Compare March 23, 2021 12:51

[RESTEASY-2700] Address PR comments.

f14a805

Some notables: use jboss-logging, add HEAD test, deal with several potential NPEs, use JDK `Collections`, and remove SniTest. SNI support can be added later (when someone needs it:)

crankydillo force-pushed the RESTEASY-2700_reactor-netty-server-adapter branch from 6f0855a to f14a805 Compare March 24, 2021 11:50

[RESTEASY-2700] Add reactor-netty entry to embedded server doc.

553a7a0

crankydillo force-pushed the RESTEASY-2700_reactor-netty-server-adapter branch from c5ce799 to 6b3e0a9 Compare April 5, 2021 20:23

jamezp reviewed Apr 12, 2021

View reviewed changes

[RESTEASY-2700] Throw NPE at the right point and make a class..

2f1edd4

package-private. [RESTEASY-2700](https://engineering.paypalcorp.com/jira/browse/RESTEASY-2700)

asoldano merged commit 5ef07c3 into resteasy:main Apr 19, 2021

lalifk mentioned this pull request Jul 12, 2022

Reactor Netty HTTP Server Support resteasy/resteasy-spring-boot#169

Merged

crankydillo mentioned this pull request Sep 6, 2022

Reactor Netty Server feature to 5.x branch resteasy/resteasy-spring-boot#184

Merged

[Resteasy-2700] reactor netty server adapter #2693

[Resteasy-2700] reactor netty server adapter #2693

Conversation

crankydillo commented Mar 16, 2021

asoldano left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asoldano commented Mar 18, 2021 • edited

asoldano commented Mar 18, 2021

jamezp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

crankydillo commented Mar 22, 2021

crankydillo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

crankydillo commented Mar 22, 2021

crankydillo commented Mar 23, 2021

abhijith-prabhakar commented Mar 23, 2021

crankydillo commented Mar 24, 2021

crankydillo commented Mar 24, 2021

crankydillo commented Mar 24, 2021

crankydillo commented Mar 29, 2021

asoldano commented Apr 1, 2021

crankydillo commented Apr 2, 2021 • edited

crankydillo commented Apr 6, 2021

asoldano commented Apr 6, 2021

crankydillo commented Apr 6, 2021

crankydillo commented Apr 9, 2021

jamezp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

crankydillo commented Apr 16, 2021

crankydillo commented Apr 19, 2021

asoldano commented Apr 19, 2021

asoldano commented Mar 18, 2021 •

edited

crankydillo commented Apr 2, 2021 •

edited