Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the chunker return the content of the chunks #3

Closed
bchapuis opened this issue Aug 29, 2015 · 2 comments
Closed

Let the chunker return the content of the chunks #3

bchapuis opened this issue Aug 29, 2015 · 2 comments

Comments

@bchapuis
Copy link
Contributor

ATM, the chunker only returns the breakpoints found in a stream of data.

type Chunk struct {
    Start  uint
    Length uint
    Cut    uint64
    Digest []byte
}

This is fine for chunking files which are read a first time for finding chunks and a second time for persisting chunks. However, this is not appropriate when dealing with stream coming from stdin such as mysql dumps. In that case, the chunker should return chunks that contains the actual bytes of the chunk.

type Chunk struct {
    Start  uint
    Length uint
    Cut    uint64
    Digest []byte
    Content []byte
}
@fd0
Copy link
Member

fd0 commented Jan 26, 2016

This bit me today: I've discovered that restic did not backup some files correctly because they changed during the backup (and the checking code detected it correctly). We should implement this.

@fd0
Copy link
Member

fd0 commented Feb 21, 2016

Addressed in 7ae4eba

@fd0 fd0 closed this as completed Feb 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants