Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Security #131 broke usernames containing '_' #182

Closed
PhracturedBlue opened this issue Feb 12, 2022 · 0 comments · Fixed by #183
Closed

Fix for Security #131 broke usernames containing '_' #182

PhracturedBlue opened this issue Feb 12, 2022 · 0 comments · Fixed by #183

Comments

@PhracturedBlue
Copy link

Output of rest-server --version 4860e044dfed

How did you run rest-server exactly?

docker run -v /storage:/data restic/rest-server

What backend/server/service did you use to store the repository?

local storage

Expected behavior

restic stopped allowing login due to my .htpasswd file haveing a username like foo_bar. This was working previoulsy and so seems to be an unintended(?) regression due to Security #131

Steps to reproduce the behavior

Care a username containing an underscore

Do you have any idea what may have caused this?

Fix for Security #131

Do you have an idea how to solve the issue?

Fix the code or remove the '_' from usernames

Did rest-server help you today? Did it make you happy in any way?

I've been a happy restic user for several years, and still continue to be one :) I am not blocked by this issue, but thought it might surprise other users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant