Flush stdout when ask for password

[gumblex]

Output of restic version

restic 0.9.4 compiled with go1.11.5 on linux/amd64
(also on git master)

How did you run restic exactly?

$ restic -r /media/backup/restic-home --verbose backup /home
open repository

What backend/server/service did you use to store the repository?

Local filesystem

Expected behavior

It should ask for password immediately.

Actual behavior

It may or may not ask for password, and stops.

Steps to reproduce the behavior

Run any command that requires password.

Do you have any idea what may have caused this?

In global.go, the Fprint is not called with a flush to stdout, so the terminal may not display the line.

Do you have an idea how to solve the issue?

Add a flush call.

Did restic help you or made you happy in any way?

Yes.

[pwilloughby]

The password prompt is printing to os.Stderr. os.Stderr is not buffered in go. There is no buffer to flush.

It looks to me like restic is not running in an interactive terminal. It will not prompt in this case.

You can see this behavior with ssh:

$ ssh remote_server restic --verbose -r /tmp/restic-home backup /home
open repository

ssh has an option to help with this -t Force pseudo-terminal allocation.

$ ssh -t remote_server restic --verbose -r /tmp/restic-home backup /home
open repository
enter password for repository: 

Were you able to resolve this issue? Are you still seeing the problem?

[MichaelEischer]

Closing this issue as I cannot reproduce it. Feel free to reopen it, if you can provide steps to reproduce.