prune: Handle --max-repack-size=0 as expected #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
force-pushed
the
prune-fix-max-repack
branch
from
d1b7cde
to
5656708
Compare
greatroar
reviewed
Dec 12, 2021
|
LGTM. |
MichaelEischer
force-pushed
the
prune-fix-max-repack
branch
2 times, most recently
from
39fa499
to
04cc82e
Compare
Previously the flag was ignored and `--max-repack-size=1` had to be used.
MichaelEischer
force-pushed
the
prune-fix-max-repack
branch
from
04cc82e
to
0cfdb82
Compare
MichaelEischer
commented
Dec 27, 2021
| if opts.MaxRepackBytes > 0 { | ||
| reachedRepackSize = stats.size.repack+p.unusedSize+p.usedSize > opts.MaxRepackBytes | ||
| } | ||
| reachedRepackSize := stats.size.repack+p.unusedSize+p.usedSize >= opts.MaxRepackBytes |
There was a problem hiding this comment.
I've change the comparison to >=. This ensures that --max-repack-size=0 really repacks nothing at all.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Previously the flag was ignored and
--max-repack-size=1had to beused instead.
Was the change previously discussed in an issue or on the forum?
Mentioned in #1153.
Checklist
[ ] I have added tests for all code changes.[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.