Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of key files tested while opening a repository #3776

Merged
merged 3 commits into from
Jun 12, 2022

Conversation

wjiec
Copy link

@wjiec wjiec commented May 30, 2022

What does this PR change? What problem does it solve?

When there are many key files in the repository and wrong passwords are
entered, the process of matching passwords is very slow. Now restic can
retry up to 20 times, or you can use -key-hint=<Key ID> to specify
the key file to be used.

Was the change previously discussed in an issue or on the forum?

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

@wjiec wjiec force-pushed the bugfix/maxkeys-in-search branch from 1cf4f33 to 36316a6 Compare May 30, 2022 07:59
changelog/unreleased/pull-3776 Outdated Show resolved Hide resolved
changelog/unreleased/pull-3776 Outdated Show resolved Hide resolved
@wjiec wjiec changed the title fix handling of maxKeys in SearchKey Limit number of key files tested while opening a repository Jun 5, 2022
@wjiec wjiec requested a review from MichaelEischer June 5, 2022 14:21
Copy link
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've rebased the PR, and tried to fix the failing test.

@MichaelEischer MichaelEischer merged commit 0c0e7b6 into restic:master Jun 12, 2022
@wjiec wjiec deleted the bugfix/maxkeys-in-search branch June 12, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants