Update golangci-lint and resolve all errors #4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
changed the title
A single test file should not use both names.
The context is required by the implemented interface.
The parameter is an additional marker that the test helper must only be used for tests.
The parameters are required by the implemented function signature or interface.
MichaelEischer
force-pushed
the
staticcheck
branch
from
43aa561
to
ecbf8e0
Compare
|
I only took a quick peek, but what I saw looks fine. |
|
@greatroar Thanks for having a look! I've added a tiny changelog for the behavior change of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Upgrade golangci-lint and resolve all errors. The majority of changes revolves around cleaning up unused parameters. golangci-lint is now configured to fail if there are any warnings in the codebase and not just in changed code.
The most noteworthy changes are that the
init/generatecommand now explicitly check that no command line arguments were passed. And the azure backend no longer honoured upload/download rate limits.Was the change previously discussed in an issue or on the forum?
No.
Checklist
[ ] I have added tests for all code changes.[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).`gofmton the code in all commits.