Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--exclude seems confused by leading & trailing slashes #499

Closed
jzacsh opened this issue Apr 16, 2016 · 1 comment · Fixed by #500
Closed

--exclude seems confused by leading & trailing slashes #499

jzacsh opened this issue Apr 16, 2016 · 1 comment · Fixed by #500
Assignees
Labels
state: need feedback waiting for feedback, e.g. from the submitter type: bug

Comments

@jzacsh
Copy link
Contributor

jzacsh commented Apr 16, 2016

Output of restic version

built from HEAD....

$ git rev-parse HEAD
5b33a7a903fc0c6d834be20c7399fe3f5ba1f210
$ bin/restic version
restic compiled manually
compiled at unknown time with go1.6

Setup

Runnig my backup with:

export TMPDIR=/tmp/
restic/restic backup \
  --repo $HOME/bak/restic \
  --exclude-file $HOME/.config/restic-exclude
  $HOME

bad report :(

Sorry for the poor bug-report quality, below, but i just spent way too long writing up my exact steps in a "micro" case, and then found opposite behavior (still broken, though)....

  • In my real-world backup (of $HOME), a leading slash confuses --exclude-file contents
  • In my test-case backup (of a mktemp -d w/2 dirs and 2 files), a leading slash has no effect (restic still backups everything indiscriminately) but removing the trailing slash from --exclude-file lines solves the problem.

So I'm not sure exact reproduction steps, unfortunately :( I only know that:

  • expected: simple[1] paths should be excluded by their presence in an --exclude-file
  • actual: said paths are almost always - except above-mentioned attempts - backed up anyway

[1]: (no globs, no env. variables, just simple paths)

@jzacsh
Copy link
Contributor Author

jzacsh commented Apr 16, 2016

i'll post back here when i have more reproduction steps (feel free to close until then, if you'd rather i figure this out first)

@fd0 fd0 added type: bug state: need feedback waiting for feedback, e.g. from the submitter labels Apr 17, 2016
@fd0 fd0 self-assigned this Apr 17, 2016
@fd0 fd0 closed this as completed in #500 Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: need feedback waiting for feedback, e.g. from the submitter type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants